Skip to content

Commit

Permalink
[libc++] [test] Run the clang-format and generated-output checks on t…
Browse files Browse the repository at this point in the history
…he "service" queue

As these jobs only run in a couple seconds, and block starting of
other jobs, they can run on the "service" queue which doesn't get
blocked by other long-running jobs.

Differential Revision: https://reviews.llvm.org/D101437
  • Loading branch information
Quuxplusone committed Apr 30, 2021
1 parent 5f51fb3 commit 6712534
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 2 deletions.
4 changes: 2 additions & 2 deletions libcxx/utils/ci/buildkite-pipeline.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ steps:
artifact_paths:
- "**/clang-format.patch"
agents:
queue: "libcxx-builders"
queue: "service"
retry:
automatic:
- exit_status: -1 # Agent was lost
Expand All @@ -40,7 +40,7 @@ steps:
artifact_paths:
- "**/generated_output.patch"
agents:
queue: "libcxx-builders"
queue: "service"
retry:
automatic:
- exit_status: -1 # Agent was lost
Expand Down
4 changes: 4 additions & 0 deletions libcxx/utils/ci/run-buildbot
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,9 @@

set -ex
set -o pipefail
unset LANG
unset LC_ALL
unset LC_COLLATE

PROGNAME="$(basename "${0}")"

Expand Down Expand Up @@ -146,6 +149,7 @@ check-generated-output)
# Check if the diffs are empty, fail otherwise.
! grep -q '^--- a' ${BUILD_DIR}/generated_output.patch || false
# Reject patches that introduce non-ASCII characters or hard tabs.
# Depends on LC_COLLATE set at the top of this script.
! grep -rn '[^ -~]' libcxx/include/ || false
# Check that no dependency cycles have been introduced.
python3 libcxx/utils/graph_header_deps.py >/dev/null
Expand Down

0 comments on commit 6712534

Please sign in to comment.