Skip to content

Commit

Permalink
Revert "[CGObjC] Add run line for release mode in test arc-exceptions…
Browse files Browse the repository at this point in the history
…-seh.mm (NFC)"

This reverts commit 01023bf. The extended test now triggers undefined behavior:
```
/b/sanitizer-aarch64-linux-bootstrap-ubsan/build/llvm-project/llvm/lib/Transforms/ObjCARC/ObjCARCOpts.cpp:577:41: runtime error: load of value 180, which is not a valid value for type 'bool'
    #0 0xaaaae3333a30 in hasCFGChanged /b/sanitizer-aarch64-linux-bootstrap-ubsan/build/llvm-project/llvm/lib/Transforms/ObjCARC/ObjCARCOpts.cpp:577:41
    #1 0xaaaae3333a30 in llvm::ObjCARCOptPass::run(llvm::Function&, llvm::AnalysisManager<llvm::Function>&) /b/sanitizer-aarch64-linux-bootstrap-ubsan/build/llvm-project/llvm/lib/Transforms/ObjCARC/ObjCARCOpts.cpp:2494:26
    ...
```
  • Loading branch information
weliveindetail committed Nov 22, 2022
1 parent 9015e41 commit a37807a
Showing 1 changed file with 8 additions and 13 deletions.
21 changes: 8 additions & 13 deletions clang/test/CodeGenObjCXX/arc-exceptions-seh.mm
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
// RUN: %clang_cc1 -triple x86_64-pc-windows-msvc -emit-llvm -fobjc-arc -fexceptions -fobjc-exceptions -fobjc-arc-exceptions -fobjc-runtime=gnustep-2.0 -o - %s | FileCheck %s --check-prefixes=CHECK,CHECK-O0
// RUN: %clang_cc1 -O2 -triple x86_64-pc-windows-msvc -emit-llvm -fobjc-arc -fexceptions -fobjc-exceptions -fobjc-arc-exceptions -fobjc-runtime=gnustep-2.0 -mllvm -enable-objc-arc-opts=false -o - %s | FileCheck %s --check-prefixes=CHECK,CHECK-O2
// RUN: %clang_cc1 -triple x86_64-pc-windows-msvc -emit-llvm -fobjc-arc -fexceptions -fobjc-exceptions -fobjc-arc-exceptions -fobjc-runtime=gnustep-2.0 -o - %s | FileCheck %s

// WinEH requires funclet tokens on nounwind intrinsics if they can lower to
// regular function calls in the course of IR transformations.
Expand Down Expand Up @@ -41,29 +40,25 @@ void try_catch_with_objc_intrinsic() {
// CHECK: [ "funclet"(token [[CATCHPAD]]) ]
// CHECK: unwind label %[[CLEANUP2]]
// CHECK: call
// CHECK-O0: @llvm.objc.storeStrong
// CHECK-O2: @llvm.objc.release
// CHECK: @llvm.objc.storeStrong
// CHECK: [ "funclet"(token [[CATCHPAD]]) ]
// CHECK-O0: catchret from [[CATCHPAD]] to label %catchret.dest
// CHECK-O2: catchret from [[CATCHPAD]] to label %eh.cont
// CHECK: catchret from [[CATCHPAD]] to label %catchret.dest
//
// In debug mode, this block exists and it's empty:
// CHECK-O0: catchret.dest:
// CHECK-O0-NEXT: br label %eh.cont
// This block exists and it's empty:
// CHECK: catchret.dest:
// CHECK-NEXT: br label %eh.cont
//
// CHECK: [[CLEANUP2]]:
// CHECK-NEXT: [[CLEANUPPAD2:%[0-9]+]] = cleanuppad within [[CATCHPAD]]
// CHECK: call
// CHECK-O0: @llvm.objc.storeStrong
// CHECK-O2: @llvm.objc.release
// CHECK: @llvm.objc.storeStrong
// CHECK: [ "funclet"(token [[CLEANUPPAD2]]) ]
// CHECK: cleanupret from [[CLEANUPPAD2]]
// CHECK: unwind label %[[CLEANUP1]]
//
// CHECK: [[CLEANUP1]]:
// CHECK-NEXT: [[CLEANUPPAD1:%[0-9]+]] = cleanuppad within none
// CHECK: call
// CHECK-O0: @llvm.objc.storeStrong
// CHECK-O2: @llvm.objc.release
// CHECK: @llvm.objc.storeStrong
// CHECK: [ "funclet"(token [[CLEANUPPAD1]]) ]
// CHECK: cleanupret from [[CLEANUPPAD1]] unwind to caller

0 comments on commit a37807a

Please sign in to comment.