-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Eccentricity Reduction Automation #6406
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a test to Test_DirectoryStructure.py
for your additions. Also see if you can adjust the tests of the BBH pipeline to test your additions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can squash all of your commits into one
f993841
to
8c2ceba
Compare
f2ba8eb
to
c5f2c6a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some tests are failing because directory names got changed. In Test_InitialData.py
and Test_Inspiral.py
you have to change the names 001_InitialData
and 002_Inspiral
to 000_InitialData
and 001_Inspiral
.
Proposed changes
Automated process for determining and reducing eccentricity.
Continuation of PR titled "Single iteration of eccentricity control reduction #6295", which also has instructions on how to run the process.
Example of directory structures for BBH simulation:
Code review checklist
make doc
to generate the documentation locally intoBUILD_DIR/docs/html
.Then open
index.html
.code review guide.
bugfix
ornew feature
if appropriate.Further comments