Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eccentricity Reduction Automation #6406

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

vtommasini
Copy link
Contributor

@vtommasini vtommasini commented Dec 10, 2024

Proposed changes

Automated process for determining and reducing eccentricity.

Continuation of PR titled "Single iteration of eccentricity control reduction #6295", which also has instructions on how to run the process.

Example of directory structures for BBH simulation:
Screenshot 2024-12-11 at 2 34 45 PM

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

Copy link
Member

@nilsvu nilsvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test to Test_DirectoryStructure.py for your additions. Also see if you can adjust the tests of the BBH pipeline to test your additions.

support/Pipelines/Bbh/EccentricityControl.py Show resolved Hide resolved
support/Pipelines/Bbh/EccentricityControl.py Outdated Show resolved Hide resolved
support/Pipelines/Bbh/EccentricityControl.py Outdated Show resolved Hide resolved
support/Pipelines/Bbh/InitialData.py Show resolved Hide resolved
support/Pipelines/Bbh/InitialData.py Show resolved Hide resolved
support/Python/DirectoryStructure.py Outdated Show resolved Hide resolved
support/Python/DirectoryStructure.py Outdated Show resolved Hide resolved
support/Python/DirectoryStructure.py Outdated Show resolved Hide resolved
support/Python/DirectoryStructure.py Outdated Show resolved Hide resolved
support/Python/Schedule.py Outdated Show resolved Hide resolved
@knelli2 knelli2 added this to the BBH Pipeline Automation milestone Dec 11, 2024
Copy link
Member

@nilsvu nilsvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can squash all of your commits into one

support/Pipelines/Bbh/EccentricityControl.py Outdated Show resolved Hide resolved
support/Python/DirectoryStructure.py Outdated Show resolved Hide resolved
@vtommasini vtommasini force-pushed the singleecccontrol branch 2 times, most recently from f993841 to 8c2ceba Compare December 16, 2024 23:36
Copy link
Member

@nilsvu nilsvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some tests are failing because directory names got changed. In Test_InitialData.py and Test_Inspiral.py you have to change the names 001_InitialData and 002_Inspiral to 000_InitialData and 001_Inspiral.

support/Pipelines/Bbh/EccentricityControl.py Outdated Show resolved Hide resolved
support/Pipelines/Bbh/InitialData.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants