Skip to content

Commit

Permalink
fix: close stdin before waiting for child process (#1464)
Browse files Browse the repository at this point in the history
  • Loading branch information
sxyazi authored Aug 11, 2024
1 parent dac72eb commit ce944bc
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions yazi-plugin/src/process/child.rs
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,7 @@ impl UserData for Child {
});

methods.add_async_method_mut("wait", |lua, me, ()| async move {
drop(me.stdin.take());
match me.inner.wait().await {
Ok(status) => (Status::new(status), Value::Nil).into_lua_multi(lua),
Err(e) => (Value::Nil, e.raw_os_error()).into_lua_multi(lua),
Expand All @@ -111,6 +112,7 @@ impl UserData for Child {
let stdout_fut = read_to_end(&mut stdout_pipe);
let stderr_fut = read_to_end(&mut stderr_pipe);

drop(me.stdin.take());
let result = try_join3(me.inner.wait(), stdout_fut, stderr_fut).await;
drop(stdout_pipe);
drop(stderr_pipe);
Expand Down

0 comments on commit ce944bc

Please sign in to comment.