Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: reuse the code previewer seeking behavior for json, archive, and empty #1721

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

sxyazi
Copy link
Owner

@sxyazi sxyazi commented Oct 3, 2024

This PR makes implementing #1328 (comment) easier — these seeking behaviors are consistent, we just use the code's seek method uniformly, so as long as the user rewrites the code's, the other previewers will just work.

@sxyazi sxyazi merged commit 034c28b into main Oct 3, 2024
6 checks passed
@sxyazi sxyazi deleted the pr-0d9487e8 branch October 3, 2024 00:21
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant