Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: introduce reflow for the rendering engine #1863

Merged
merged 2 commits into from
Oct 30, 2024
Merged

perf: introduce reflow for the rendering engine #1863

merged 2 commits into from
Oct 30, 2024

Conversation

sxyazi
Copy link
Owner

@sxyazi sxyazi commented Oct 30, 2024

Previously, when the terminal size changed, it required two complete renderings: the first rendered a virtual frame with the new size, and the information from that frame was applied to the second rendering.

This PR introduces the new concept of "reflow", which has almost no overhead compared to rendering, and the actual rendering only needs to happen once, and only the changes detected during reflow will trigger it

Also fixes #1855

@sxyazi sxyazi merged commit c668723 into main Oct 30, 2024
6 checks passed
@sxyazi sxyazi deleted the pr-ac3c8bc6 branch October 30, 2024 11:06
mikavilpas added a commit to mikavilpas/yazi.nvim that referenced this pull request Oct 30, 2024
This includes a rerendering change introduced in the following pull
request:

- sxyazi/yazi#1863
mikavilpas added a commit to mikavilpas/yazi.nvim that referenced this pull request Oct 30, 2024
This includes a rerendering change introduced in the following pull
request:

- sxyazi/yazi#1863
dedukun added a commit to dedukun/relative-motions.yazi that referenced this pull request Oct 31, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No re-render is triggered when the terminal size changes and CWD is empty
1 participant