-
Notifications
You must be signed in to change notification settings - Fork 421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Ctrl-[
as an escape key
#763
Conversation
Thanks for your PR!
However, if this could enhance user experience, I can accept adding it, but I'm sorry I can't accept |
I see. Quite a few Vim users' would find it easier to use Ctrl + [ instead of Esc, including me, so it'll improve the user experience to have it implemented by default. Got it, I'll remove the ^ key binding. I'm assuming that Ctrl + c as an alternative for Esc wouldn't be wanted as well since it behaves slightly differently from the Esc key in Vim? |
I will add Thank you for contributing to this feature, let's merge it now! |
Ctrl-[
as an escape key
I see, that’s great! Looking forward to that change. Thanks for merging my pull request! |
* ci: add cachix workflow (sxyazi#740) * feat: add hovered as `$0` for shell and opener (sxyazi#738) * feat: flavor (sxyazi#753) * feat: add a new `[notify]` section to the `theme.toml` to configure the `notify` component's style (sxyazi#749) * feat: switch to inline images protocol for VSCode, Tabby, and Hyper * feat: add `prepend_rules` and `append_rules` for `[open]` in `yazi.toml` (sxyazi#754) * feat: support `YAZI_FILE_ONE` environment variable for `file(1)` path (sxyazi#752) * feat: allow both '/' and '\' in folder creation (sxyazi#751) * perf: apply `add_many()`/`remove_many()` to the visual mode items for selection conflict detecting (sxyazi#758) * feat: support `%0` as the hovered file for Windows (sxyazi#761) * feat: `ya.input()` plugin API (sxyazi#762) * fix: remove redundant check to allow operations on the `shell` command with an empty file list * feat: add musl linux build targets (sxyazi#759) * fix: nested conflict detection exception when performing cross-level searches (sxyazi#769) * refactor: add new `run` property (sxyazi#773) * feat: add `Ctrl-[` as an escape key (sxyazi#763) * feat: add `parse` method to `Line` element * feat: `ya.notify()` plugin API (sxyazi#780) --------- Co-authored-by: musjj <72612857+musjj@users.noreply.github.com> Co-authored-by: rrveex <91850165+rrveex@users.noreply.github.com> Co-authored-by: sxyazi <sxyazi@gmail.com> Co-authored-by: little camel <54983536+evpeople@users.noreply.github.com> Co-authored-by: Filipe Paniguel <paniguel.lpnh@gmail.com> Co-authored-by: Nguyễn Đức Toàn <33489972+ndtoan96@users.noreply.github.com> Co-authored-by: Konrad Baran <65494005+uznog@users.noreply.github.com> Co-authored-by: hankertrix <91734413+hankertrix@users.noreply.github.com>
In Vim, Ctrl + [ is an alternative to using the key and behaves exactly the same way. This pull request adds that functionality to Yazi.
Also added ^ as a key to move to the beginning of the line, like in Vim. This is a little inaccurate as in Vim, the ^ key moves to the first non-whitespace character in a line, not to the beginning of the line, but I think for the use cases in Yazi, the ^ key being the same as the 0 key shouldn't be much of an issue.