Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add new move, trash, and delete event kinds to DDS #880

Merged
merged 13 commits into from
Apr 10, 2024
Merged

feat: add new move, trash, and delete event kinds to DDS #880

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
0bc5529
feat: cut and paste (x -> p) sends new "move" events
mikavilpas Apr 6, 2024
adeaf0d
refactor: reorder payload types
mikavilpas Apr 6, 2024
872a6a4
refactor: rename move_event.rs to move_.rs
mikavilpas Apr 6, 2024
63b20ba
WIP: refactor: send the move events after moving is successful
mikavilpas Apr 6, 2024
bfdbe4f
Format
sxyazi Apr 8, 2024
57d4509
Reorder
sxyazi Apr 8, 2024
c16c929
Add `delete` kind
sxyazi Apr 9, 2024
d6e5f72
..
sxyazi Apr 10, 2024
bbb8c3c
..
sxyazi Apr 10, 2024
ed91358
..
sxyazi Apr 10, 2024
9f3229a
feat: emit "delete" event when moving a file to the trash
mikavilpas Apr 10, 2024
0a93a4e
feat: add "trash" event for trashing files
mikavilpas Apr 10, 2024
e0077f6
Minor changes
sxyazi Apr 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion yazi-scheduler/src/scheduler.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,8 @@ impl Scheduler {
let file = self.file.clone();
_ = self.micro.try_send(
async move {
file.trash(FileOpTrash { id, target, length: 0 }).await.ok();
file.trash(FileOpTrash { id, target: target.clone(), length: 0 }).await.ok();
Pump::push_delete(target);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really like adding trash to delete because they're two different concepts, I think it deserves a new trash event kind.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I'll add a new event kind. It should be much simpler after the latest changes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok it's done now and seems to work
image

}
.boxed(),
LOW,
Expand Down