Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: trigger path completion with both / and \ on Windows #909

Merged
merged 3 commits into from
Apr 14, 2024

Conversation

ndtoan96
Copy link
Contributor

Fix some issues described in #782:

  • Trigger completion with both / and \.
  • Normalized path with MAIN_SEPARATOR when pressing tab for completion.

I've implemented them in Windows specific code. Because Linux apparently allows \ in file name.

@ndtoan96 ndtoan96 changed the title feat: Trigger path completion with both / and \ feat: Trigger path completion with both / and \ on Windows Apr 14, 2024
@ndtoan96
Copy link
Contributor Author

Demo:

Recording.2024-04-14.125229.mp4

@sxyazi
Copy link
Owner

sxyazi commented Apr 14, 2024

Thanks for the PR! I've made some simplifications

@sxyazi sxyazi changed the title feat: Trigger path completion with both / and \ on Windows feat: trigger path completion with both / and \ on Windows Apr 14, 2024
@sxyazi sxyazi merged commit f442ae2 into sxyazi:main Apr 14, 2024
5 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants