-
Notifications
You must be signed in to change notification settings - Fork 421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: avoiding duplicate candidates in the which
component
#975
fix: avoiding duplicate candidates in the which
component
#975
Conversation
Thanks for the PR! I don't think this test is necessary because It contains unsafe code, so currently, it's restricted to only being used in the Line 33 in 3a09155
|
7db2354
to
b862576
Compare
I think that makes sense. I actually noticed there were issues trying to add another test, probably because the The test has now been removed. |
not familiar with the codebase. is it getting deduplicated each time it displays command suggestions? |
Yes, duplicates are removed every time. @sxyazi I just noticed this doesn't yet preserve the order of the suggestions, so the suggestions can appear in a random order now. I'll fix this soon. |
b862576
to
0f02b9e
Compare
Ok, order is now preserved 🙂 |
Thanks! |
which
component
I like your refactoring, nicely done 👍🏻 |
Fixes #955
Also added a test for this bug as a suggestion.
Let me know how you would prefer testing to be done in this project!