fix: add cache for getAstTitle in typescript parser #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@ArnaudBarre is attempting to deploy a commit to the sxzz's projects Team on Vercel. A member of the Team first needs to authorize it. |
sxzz
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I left this comment on a previous PR and I since wonder what was the perf impact. It was less bad than expected: 4ms per keystroke on my Mac for a 1.4k lines file (Vite's optimizer/index.ts). But I don't think people will use it with that much code. Anyway once checkout it was cheap to make the PR, I let you decide if you want to merge it or not.