Avoid possible shadowing of existing bindings

sycamore-rs · Aug 31, 2022 · 7a69a96 · 7a69a96
1 parent 5de8f76
commit 7a69a96
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 4 deletions.
diff --git a/packages/sycamore-macro/src/view/codegen.rs b/packages/sycamore-macro/src/view/codegen.rs
@@ -27,14 +27,14 @@ impl Codegen {
                     .iter()
                     .map(|node| {
                         let quoted = self.view_node(node);
-                        quote! { children.push(#quoted); }
+                        quote! { #quoted, }
                     })
                     .collect();
                 quote! {
                     ::sycamore::view::View::new_fragment({
-                        let mut children = ::std::vec::Vec::new();
-                        #append_nodes
-                        children
+                        ::std::vec![
+                            #append_nodes
+                        ]
                     })
                 }
             }

diff --git a/packages/sycamore-macro/tests/view/component-pass.rs b/packages/sycamore-macro/tests/view/component-pass.rs
@@ -22,6 +22,18 @@ pub fn ComponentWithChildren<'a, G: Html>(cx: Scope<'a>, prop: PropWithChildren<
     prop.children.call(cx)
 }
 
+#[component]
+pub fn NestedComponentWithChildren<'a, G: Html>(cx: Scope<'a>, prop: PropWithChildren<'a, G>) -> View<G> {
+    let children = prop.children.call(cx);
+
+    view! { cx,
+        ComponentWithChildren {
+            (children)
+            Component {}
+        }
+    }
+}
+
 #[component]
 pub async fn AsyncComponentWithPropDestructuring<'a, G: Html>(
     cx: Scope<'a>,
@@ -61,6 +73,12 @@ fn compile_pass<G: Html>() {
                 Component {}
             }
         };
+
+        let _: View<G> = view! { cx,
+            NestedComponentWithChildren {
+                Component {}
+            }
+        };
     });
 }