Skip to content

Commit

Permalink
Move web-sys features from sycamore to sycamore-web (#644)
Browse files Browse the repository at this point in the history
  • Loading branch information
lukechu10 authored Oct 20, 2023
1 parent 28b9106 commit 9beed52
Show file tree
Hide file tree
Showing 2 changed files with 28 additions and 47 deletions.
28 changes: 27 additions & 1 deletion packages/sycamore-web/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ web-sys = { version = "0.3.60", features = [
"DocumentFragment",
"DomTokenList",
"Element",
"Event",
"HtmlCollection",
"HtmlElement",
"HtmlInputElement",
Expand All @@ -35,6 +34,33 @@ web-sys = { version = "0.3.60", features = [
"NodeList",
"Text",
"Window",
# Event types
"AnimationEvent",
"BeforeUnloadEvent",
"CompositionEvent",
"DeviceMotionEvent",
"DeviceOrientationEvent",
"DragEvent",
"ErrorEvent",
"Event",
"FocusEvent",
"GamepadEvent",
"HashChangeEvent",
"InputEvent",
"KeyboardEvent",
"MessageEvent",
"MouseEvent",
"PageTransitionEvent",
"PointerEvent",
"PopStateEvent",
"ProgressEvent",
"PromiseRejectionEvent",
"SecurityPolicyViolationEvent",
"StorageEvent",
"SubmitEvent",
"TouchEvent",
"TransitionEvent",
"WheelEvent",
] }

[dev-dependencies]
Expand Down
47 changes: 1 addition & 46 deletions packages/sycamore/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -25,52 +25,7 @@ sycamore-reactive = { path = "../sycamore-reactive", version = "0.9.0-beta.2" }
sycamore-web = { path = "../sycamore-web", version = "0.9.0-beta.2", optional = true }
wasm-bindgen = { version = "0.2.83", optional = true }
wasm-bindgen-futures = { version = "0.4.33", optional = true }

[dependencies.web-sys]
features = [
"console",
"Comment",
"Document",
"DocumentFragment",
"DomTokenList",
"Element",
"HtmlElement",
"HtmlInputElement",
"HtmlCollection",
"Node",
"NodeList",
"Text",
"Window",
# Event types
"AnimationEvent",
"BeforeUnloadEvent",
"CompositionEvent",
"DeviceMotionEvent",
"DeviceOrientationEvent",
"DragEvent",
"ErrorEvent",
"Event",
"FocusEvent",
"GamepadEvent",
"HashChangeEvent",
"InputEvent",
"KeyboardEvent",
"MessageEvent",
"MouseEvent",
"PageTransitionEvent",
"PointerEvent",
"PopStateEvent",
"ProgressEvent",
"PromiseRejectionEvent",
"SecurityPolicyViolationEvent",
"StorageEvent",
"SubmitEvent",
"TouchEvent",
"TransitionEvent",
"WheelEvent",
]
version = "0.3.60"
optional = true
web-sys = { version = "0.3.60", optional = true }

[dev-dependencies]
expect-test = "1.4.0"
Expand Down

1 comment on commit 9beed52

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.30.

Benchmark suite Current: 9beed52 Previous: 28b9106 Ratio
reactivity_context_deeply_nested 3341 ns/iter (± 1034) 1855 ns/iter (± 449) 1.80

This comment was automatically generated by workflow using github-action-benchmark.

CC: @lukechu10

Please sign in to comment.