Faster effects (#159)

* Do not clear old dependencies on initial * Subscribe/unsubscribe signals only belonging to diff * Revert "Subscribe/unsubscribe signals only belonging to diff" This reverts commit db0ef30.
sycamore-rs · Jul 8, 2021 · f8f0e3d · f8f0e3d
1 parent a68f6c9
commit f8f0e3d
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/packages/sycamore/src/rx/effect.rs b/packages/sycamore/src/rx/effect.rs
@@ -179,9 +179,6 @@ pub fn create_effect_initial<R: 'static>(
                     // the effect.
                     let running = running.upgrade().unwrap();
 
-                    // Recreate effect dependencies each time effect is called.
-                    running.borrow_mut().as_mut().unwrap().clear_dependencies();
-
                     // Push new reactive scope.
                     contexts.borrow_mut().push(Rc::downgrade(&running));
 
@@ -196,6 +193,9 @@ pub fn create_effect_initial<R: 'static>(
                         });
                         running.borrow_mut().as_mut().unwrap().scope = scope;
                     } else {
+                        // Recreate effect dependencies each time effect is called.
+                        running.borrow_mut().as_mut().unwrap().clear_dependencies();
+
                         // Destroy old effects before new ones run.
 
                         // We want to destroy the old scope before creating the new one, so that