Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Segment should implement Clone #230

Closed
arctic-hen7 opened this issue Sep 10, 2021 · 0 comments · Fixed by #232
Closed

Segment should implement Clone #230

arctic-hen7 opened this issue Sep 10, 2021 · 0 comments · Fixed by #232
Labels
C-bug Category: bug, something isn't working

Comments

@arctic-hen7
Copy link
Contributor

Describe the bug
The Segment type in sycamore-router should implement Clone for convenience of working with the routing internals.

To Reproduce
Try cloning any Segment. In my case it was through .to_vec() on a Vec<Segment>.

Expected behavior
Segment should implement Clone.

Environment

  • Sycamore: v0.5.2
@arctic-hen7 arctic-hen7 added the C-bug Category: bug, something isn't working label Sep 10, 2021
This was referenced Sep 11, 2021
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-bug Category: bug, something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Derived Clone for router types
Derived Clone for router types
1 participant
@arctic-hen7