Derived Clone for router types
#232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specifically `Segment`, `RoutePath`, and `Capture`.
|
I hope to release 0.6 soon so this will be part of the next release. |
|
lgtm, thanks for contributing! |
|
Fantastic, thanks! My pleasure, all three lines! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This just derives the
Clonetrait for the sycamore-router typesSegment,Capture, andRoutePath, which makes it much easier to work with the routing internals. This is different to #231 in that it operated onv0.5.2instead ofmaster!This fixes #230.