Hydration duplicates interpolated variables #319
Comments
|
This has been fixed for dynamic nodes that are children of elements, e.g. view! {
div {
(dynamic_value)
}
}but doesn't work for dynamic nodes at the top-level, e.g. view! {
(dynamic_value)
}This proved to be a much harder problem to solve and would probably require a lot of refactors so it's nothing I can fix quickly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
When hydrating a view rendered with SSR, any interpolated variables will be duplicated at the element-level.
To Reproduce
Steps to reproduce the behavior:
sycamore::render_to_string().<body>of your page withweb_sys.sycamore::hydrate().Hello World!Hello World!).This can also be observed in Perseus from
v0.3.0-beta.22by creating a page that interpolates a value and then enabling thehydratefeature, which enables Sycamore's hydration (and follows a very similar process to that described above).Expected behavior
Interpolated values should be removed, recomputed, and rendered without duplication.
Screenshots
If applicable, add screenshots to help explain your problem.
Environment
Additional context
An MRE for this issue is available here. Use
trunk serveto run it and observe the issue in a browser.I assume this is caused by simply not removing the old interpolated values, which I understand would be difficult without knowing exactly what they are. My (perhaps very naive) suggestion would be to identify the smallest number of elements within a component that have interpolated values, and then remove those, recomputing the new values. Alternatively, a more nuanced approach could be taken of isolated interpolated values within strings etc., though this may have a large runtime performance cost (but I'm unfamiliar with this part of the Sycamore codebase, so I honestly have no idea).
The text was updated successfully, but these errors were encountered: