Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hack to fix duplicate text when hydrating #321

Merged
merged 1 commit into from
Dec 15, 2021

Conversation

lukechu10
Copy link
Member

@lukechu10 lukechu10 commented Dec 15, 2021

This fixes a bug where dynamic text nodes are the single child of parent would be inserted twice when hydrating on the client side.

Fixes #319

Verified

This commit was signed with the committer’s verified signature.
@lukechu10 lukechu10 added C-bug Category: bug, something isn't working A-SSR Area: Server Side Rendering (SSR) and Static Site Generation (SSG) A-hydration Area: client-side hydration labels Dec 15, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #321 (93a023e) into master (e64f95b) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #321      +/-   ##
==========================================
+ Coverage   73.30%   73.33%   +0.03%     
==========================================
  Files          38       38              
  Lines        5331     5337       +6     
==========================================
+ Hits         3908     3914       +6     
  Misses       1423     1423              
Impacted Files Coverage Δ
packages/sycamore/src/utils/render.rs 58.49% <100.00%> (+0.96%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e64f95b...93a023e. Read the comment docs.

@lukechu10 lukechu10 merged commit 7dc8cbe into master Dec 15, 2021
@lukechu10 lukechu10 deleted the fix-hydration-interpolation branch December 15, 2021 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-hydration Area: client-side hydration A-SSR Area: Server Side Rendering (SSR) and Static Site Generation (SSG) C-bug Category: bug, something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hydration duplicates interpolated variables
2 participants