Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow effects to be FnMut #103

Merged
merged 2 commits into from
Apr 24, 2021
Merged

Allow effects to be FnMut #103

merged 2 commits into from
Apr 24, 2021

Conversation

lukechu10
Copy link
Member

No description provided.

@lukechu10 lukechu10 added C-enhancement Category: new feature or improvement to existing feature A-reactivity Area: reactivity and state handling labels Apr 24, 2021
@lukechu10 lukechu10 merged commit 17f477f into template-result-text Apr 24, 2021
@lukechu10 lukechu10 deleted the fnmut-effects branch April 24, 2021 19:04
lukechu10 added a commit that referenced this pull request Jun 1, 2021
* Allow effects to be FnMut

* Only add -Dwarnings for clippy
lukechu10 added a commit that referenced this pull request Jun 7, 2021
* rust_2018_idioms

* Ccorrectly stringify self-closing tags in SSR

* Rename render to create

* Move render_* functions into sub-modules

* Naive hydration

* get_children utility

* Add mapped and indexed placeholder

* Allow effects to be FnMut (#103)

* Allow effects to be FnMut

* Only add -Dwarnings for clippy

* Set CARGO_TERM_COLOR to always

* map_indexed

* Implement map_keyed

* Add fast paths for map_keyed

* Make TemplateResult recursive

* Make map_* return closures

* Refactor TemplateResult

* Add a Lazy TemplateResult

* Allow create_memo and create_selector to take FnMut

* Fix unit tests

* Change TemplateResultInner::Lazy to be FnMut

* insert_expression node and lazy

* Make most of the tests pass

* Remove append_render

* Make Lazy work

* Fix reactivity

* Make fragment template work

* renconcile_fragments

* Support TemplateResult in interpolation syntax

* wip

* wip

* Push lazy TemplateResult to normalized

* wip

* wip

* NodeId

* Add renconcile tests

* Add reconcile do not clone node test

* Update wasm-bindgen to 0.2.74 in CI

* Interpolation nested reactivity test

* Remove Option from TemplateResultInner::Lazy type

* cargo clippy

* Append fragment nodes at the right location

* wip

* refactor

* refactor

* Fix map_keyed

* Fix clippy

* Remove unused NodeRef in TodoMVC example

* Remove fragment from GenericNode

* Remove Fragment from SsrNode

* Refactor SsrNode::try_remove_child

* Deprecate TemplateResult::flatten

* Change Render to IntoTemplate

* Refactor rendering of template fragments

* Rewrite impl ToTokens for Element

* Split up ToTokens in element.rs

* Visitor pattern for Html nodes

* TemplateVisitor

* Insert components and interpolated values before a marker

* Fix nested fragments

* Lazy in fragment test

* Fix DomNode::replace_child

* Fix Indexed and Keyed

* Fix iteration example

* Fix reconcile

* Pass the wasm test suite!!!

* Fix the ssr test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-reactivity Area: reactivity and state handling C-enhancement Category: new feature or improvement to existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant