Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Router use anchor tags #128

Merged
merged 2 commits into from
Jun 27, 2021
Merged

Router use anchor tags #128

merged 2 commits into from
Jun 27, 2021

Conversation

lukechu10
Copy link
Member

Closes #125

@lukechu10 lukechu10 added performance Performance related A-ergonomics Area: API ergonomics A-router Area: router labels Jun 27, 2021
@github-actions

This comment has been minimized.

@lukechu10 lukechu10 added performance Performance related and removed performance Performance related labels Jun 27, 2021
@github-actions

This comment has been minimized.

@lukechu10 lukechu10 added performance Performance related and removed performance Performance related labels Jun 27, 2021
@github-actions
Copy link

github-actions bot commented Jun 27, 2021

Finished dev [unoptimized + debuginfo] target(s) in 0.01s
 Running `target/debug/results_diff`

Benchmark Report

  • wasm-bindgen: the performance goal
  • baseline: performance of sycamore-baseline (typically latest master)
  • update: performance of sycamore (typically recent changes)
  • diff: measures the improvement of update over the baseline
@@                         Performance Diff                          @@

##                       | wasm-bindgen | baseline |  update |  diff ##
#######################################################################
- 01_run1k               |       137.55 |   235.00 |  247.62 |   +5.37%
+ 02_replace1k           |       157.01 |   224.97 |  211.79 |   -5.86%
+ 03_update10th1k_x16    |       259.19 |   272.04 |  257.45 |   -5.36%
+ 04_select1k            |        37.18 |    67.72 |   55.78 |  -17.64%
+ 05_swap1k              |        70.14 |    73.82 |   71.83 |   -2.68%
  06_remove-one-1k       |        27.14 |    29.30 |   28.88 |   -1.46%
- 07_create10k           |      1506.08 |  6952.94 | 7856.99 |  +13.00%
- 08_create1k-after1k_x2 |       335.98 |   546.14 |  560.46 |   +2.62%
- 09_clear1k_x8          |       214.00 |   256.38 |  285.38 |  +11.31%
  21_ready-memory        |         1.02 |     1.02 |    1.02 |   -0.00%
  22_run-memory          |         1.50 |     2.25 |    2.25 |   -0.00%
  23_update5-memory      |         1.82 |     2.57 |    2.57 |   +0.00%
- 24_run5-memory         |         2.11 |     2.73 |    2.81 |   +3.02%
  25_run-clear-memory    |         2.25 |     2.30 |    2.30 |   +0.00%
+ 31_startup-ci          |      1944.44 |  2011.03 | 1959.18 |   -2.58%
- 32_startup-bt          |        60.53 |    34.75 |   48.84 |  +40.56%
  34_startup-totalbytes  |       197.35 |   324.53 |  324.54 |   +0.00%

Workflow: [975515441](/sycamore-rs/sycamore/actions/runs/975515441) *Adding new commits will generate a new report*

@lukechu10 lukechu10 enabled auto-merge (squash) June 27, 2021 17:57
@github-actions
Copy link

github-actions bot commented Jun 27, 2021

Finished dev [unoptimized + debuginfo] target(s) in 0.01s
 Running `target/debug/results_diff`

Benchmark Report

  • wasm-bindgen: the performance goal
  • baseline: performance of sycamore-baseline (typically latest master)
  • update: performance of sycamore (typically recent changes)
  • diff: measures the improvement of update over the baseline
@@                         Performance Diff                          @@

##                       | wasm-bindgen | baseline |  update |  diff ##
#######################################################################
- 01_run1k               |       141.97 |   245.06 |  252.40 |   +3.00%
+ 02_replace1k           |       154.41 |   229.14 |  222.29 |   -2.99%
  03_update10th1k_x16    |       258.26 |   265.91 |  262.28 |   -1.37%
  04_select1k            |        44.34 |    56.32 |   56.33 |   +0.00%
  05_swap1k              |        63.51 |    75.13 |   75.00 |   -0.18%
  06_remove-one-1k       |        29.30 |    30.00 |   30.11 |   +0.34%
  07_create10k           |      1548.71 |  7892.93 | 7894.06 |   +0.01%
- 08_create1k-after1k_x2 |       340.22 |   565.45 |  588.27 |   +4.03%
  09_clear1k_x8          |       210.10 |   280.23 |  279.82 |   -0.15%
  21_ready-memory        |         1.02 |     1.02 |    1.02 |   +0.00%
  22_run-memory          |         1.50 |     2.25 |    2.25 |   -0.01%
  23_update5-memory      |         1.82 |     2.57 |    2.57 |   -0.00%
  24_run5-memory         |         2.11 |     2.81 |    2.81 |   +0.00%
  25_run-clear-memory    |         2.25 |     2.30 |    2.30 |   +0.00%
  31_startup-ci          |      1907.22 |  1972.13 | 1963.95 |   -0.41%
+ 32_startup-bt          |        49.64 |    57.00 |   46.92 |  -17.69%
  34_startup-totalbytes  |       197.35 |   324.53 |  324.54 |   +0.00%

Workflow: [976697664](/sycamore-rs/sycamore/actions/runs/976697664) *Adding new commits will generate a new report*

@lukechu10 lukechu10 merged commit 5923d32 into master Jun 27, 2021
@lukechu10 lukechu10 deleted the router-use-anchor branch June 27, 2021 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ergonomics Area: API ergonomics A-router Area: router performance Performance related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Router use plain links (<a>) instead of Link component
1 participant