Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary Rc<RefCell<_>>s #141

Merged
merged 5 commits into from
Jul 3, 2021
Merged

Remove unnecessary Rc<RefCell<_>>s #141

merged 5 commits into from
Jul 3, 2021

Conversation

lukechu10
Copy link
Member

No description provided.

@lukechu10 lukechu10 added the performance Performance related label Jul 3, 2021
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions
Copy link

github-actions bot commented Jul 3, 2021

Finished dev [unoptimized + debuginfo] target(s) in 0.01s
 Running `target/debug/results_diff`

Benchmark Report

  • wasm-bindgen: the performance goal
  • baseline: performance of sycamore-baseline (typically latest master)
  • update: performance of sycamore (typically recent changes)
  • diff: measures the improvement of update over the baseline
@@                         Performance Diff                          @@

##                       | wasm-bindgen | baseline |  update |  diff ##
#######################################################################
- 01_run1k               |       147.82 |   222.13 |  227.82 |   +2.56%
+ 02_replace1k           |       175.13 |   235.48 |  226.75 |   -3.71%
  03_update10th1k_x16    |       358.29 |   398.70 |  396.39 |   -0.58%
- 04_select1k            |        59.96 |    76.48 |   80.36 |   +5.07%
+ 05_swap1k              |        83.05 |    92.00 |   89.44 |   -2.79%
- 06_remove-one-1k       |        33.16 |    32.18 |   33.80 |   +5.03%
- 07_create10k           |      1665.22 |  7184.33 | 7435.40 |   +3.49%
+ 08_create1k-after1k_x2 |       388.48 |   597.23 |  580.77 |   -2.76%
- 09_clear1k_x8          |       265.45 |   333.90 |  344.03 |   +3.03%
  21_ready-memory        |         1.02 |     1.02 |    1.02 |   -0.00%
  22_run-memory          |         1.50 |     1.96 |    1.96 |   -0.00%
  23_update5-memory      |         1.82 |     2.27 |    2.27 |   -0.00%
+ 24_run5-memory         |         2.11 |     2.51 |    2.44 |   -2.99%
  25_run-clear-memory    |         2.25 |     2.20 |    2.20 |   -0.00%
  31_startup-ci          |      2006.39 |  1956.97 | 1969.79 |   +0.66%
+ 32_startup-bt          |        75.35 |    77.41 |   45.52 |  -41.19%
  34_startup-totalbytes  |       197.35 |   323.02 |  318.51 |   -1.39%

Workflow: [997160018](/sycamore-rs/sycamore/actions/runs/997160018) *Adding new commits will generate a new report*

@github-actions
Copy link

github-actions bot commented Jul 3, 2021

Finished dev [unoptimized + debuginfo] target(s) in 0.01s
 Running `target/debug/results_diff`

Benchmark Report

  • wasm-bindgen: the performance goal
  • baseline: performance of sycamore-baseline (typically latest master)
  • update: performance of sycamore (typically recent changes)
  • diff: measures the improvement of update over the baseline
@@                         Performance Diff                          @@

##                       | wasm-bindgen | baseline |  update |  diff ##
#######################################################################
- 01_run1k               |       124.62 |   186.90 |  194.12 |   +3.86%
- 02_replace1k           |       140.28 |   180.35 |  187.94 |   +4.21%
+ 03_update10th1k_x16    |       230.18 |   258.78 |  247.88 |   -4.21%
- 04_select1k            |        39.26 |    52.57 |   58.48 |  +11.23%
  05_swap1k              |        68.25 |    74.03 |   73.42 |   -0.82%
  06_remove-one-1k       |        27.86 |    28.73 |   28.98 |   +0.87%
- 07_create10k           |      1277.42 |  5943.08 | 6125.08 |   +3.06%
+ 08_create1k-after1k_x2 |       286.34 |   447.29 |  434.16 |   -2.94%
+ 09_clear1k_x8          |       179.71 |   231.35 |  221.52 |   -4.25%
  21_ready-memory        |         1.02 |     1.02 |    1.02 |   -0.01%
  22_run-memory          |         1.50 |     1.96 |    1.96 |   -0.01%
  23_update5-memory      |         1.82 |     2.27 |    2.27 |   -0.15%
+ 24_run5-memory         |         2.11 |     2.52 |    2.44 |   -3.30%
  25_run-clear-memory    |         2.25 |     2.20 |    2.20 |   -0.09%
- 31_startup-ci          |      1970.92 |  1955.74 | 2006.75 |   +2.61%
+ 32_startup-bt          |        26.55 |    60.91 |   56.93 |   -6.53%
  34_startup-totalbytes  |       197.35 |   323.02 |  318.51 |   -1.39%

Workflow: [997175912](/sycamore-rs/sycamore/actions/runs/997175912) *Adding new commits will generate a new report*

@sycamore-rs sycamore-rs deleted a comment from github-actions bot Jul 3, 2021
@lukechu10 lukechu10 added performance Performance related and removed performance Performance related labels Jul 3, 2021
@github-actions
Copy link

github-actions bot commented Jul 3, 2021

Finished dev [unoptimized + debuginfo] target(s) in 0.01s
 Running `target/debug/results_diff`

Benchmark Report

  • wasm-bindgen: the performance goal
  • baseline: performance of sycamore-baseline (typically latest master)
  • update: performance of sycamore (typically recent changes)
  • diff: measures the improvement of update over the baseline
@@                         Performance Diff                          @@

##                       | wasm-bindgen | baseline |  update |  diff ##
#######################################################################
- 01_run1k               |       136.83 |   210.02 |  215.24 |   +2.48%
  02_replace1k           |       150.36 |   206.62 |  206.28 |   -0.16%
- 03_update10th1k_x16    |       243.15 |   231.90 |  250.68 |   +8.10%
+ 04_select1k            |        39.00 |    51.21 |   48.10 |   -6.07%
  05_swap1k              |        68.76 |    74.63 |   75.06 |   +0.59%
+ 06_remove-one-1k       |        28.82 |    29.88 |   28.95 |   -3.11%
+ 07_create10k           |      1478.58 |  6504.11 | 6003.03 |   -7.70%
  08_create1k-after1k_x2 |       328.02 |   492.76 |  495.95 |   +0.65%
  09_clear1k_x8          |       211.25 |   273.72 |  273.47 |   -0.09%
  21_ready-memory        |         1.02 |     1.02 |    1.02 |   -0.01%
  22_run-memory          |         1.50 |     1.96 |    1.96 |   -0.00%
  23_update5-memory      |         1.82 |     2.27 |    2.27 |   -0.00%
  24_run5-memory         |         2.11 |     2.43 |    2.44 |   +0.29%
  25_run-clear-memory    |         2.25 |     2.20 |    2.20 |   -0.00%
  31_startup-ci          |      1942.05 |  2003.94 | 1997.11 |   -0.34%
- 32_startup-bt          |        42.33 |    36.28 |   51.65 |  +42.36%
  34_startup-totalbytes  |       197.35 |   323.02 |  318.51 |   -1.39%

Workflow: [997206735](/sycamore-rs/sycamore/actions/runs/997206735) *Adding new commits will generate a new report*

@lukechu10 lukechu10 merged commit ef17572 into master Jul 3, 2021
@lukechu10 lukechu10 deleted the remove-useless-rcs branch July 3, 2021 23:21
@lukechu10 lukechu10 mentioned this pull request Jul 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance Performance related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant