Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Context API #169

Merged
merged 8 commits into from
Jul 12, 2021
Merged

Context API #169

merged 8 commits into from
Jul 12, 2021

Conversation

lukechu10
Copy link
Member

No description provided.

@lukechu10 lukechu10 added C-enhancement Category: new feature or improvement to existing feature A-reactivity Area: reactivity and state handling performance Performance related labels Jul 11, 2021
@lukechu10 lukechu10 marked this pull request as draft July 11, 2021 21:25
@github-actions
Copy link

github-actions bot commented Jul 11, 2021 •
edited
Loading 

Finished dev [unoptimized + debuginfo] target(s) in 0.01s
 Running `target/debug/results_diff`

Benchmark Report

  • wasm-bindgen: the performance goal
  • baseline: performance of sycamore-baseline (typically latest master)
  • update: performance of sycamore (typically recent changes)
  • diff: measures the improvement of update over the baseline
@@                         Performance Diff                          @@

##                       | wasm-bindgen | baseline |  update |  diff ##
#######################################################################
- 01_run1k               |       123.56 |   156.59 |  165.68 |   +5.81%
  02_replace1k           |       139.41 |   173.30 |  174.10 |   +0.46%
+ 03_update10th1k_x16    |       248.89 |   243.15 |  218.76 |  -10.03%
+ 04_select1k            |        36.47 |    50.55 |   49.23 |   -2.62%
+ 05_swap1k              |        70.32 |    72.25 |   66.93 |   -7.36%
  06_remove-one-1k       |        28.02 |    28.97 |   28.90 |   -0.23%
+ 07_create10k           |      1293.71 |  3823.76 | 3713.97 |   -2.87%
- 08_create1k-after1k_x2 |       282.55 |   382.98 |  391.69 |   +2.28%
- 09_clear1k_x8          |       179.51 |   199.75 |  208.90 |   +4.58%
  21_ready-memory        |         1.02 |     1.02 |    1.02 |   +0.00%
  22_run-memory          |         1.50 |     1.80 |    1.80 |   -0.17%
  23_update5-memory      |         1.82 |     2.12 |    2.09 |   -1.15%
  24_run5-memory         |         2.11 |     2.40 |    2.40 |   -0.03%
  25_run-clear-memory    |         2.25 |     2.26 |    2.26 |   -0.10%
- 31_startup-ci          |      1887.90 |  1955.51 | 2007.96 |   +2.68%
- 32_startup-bt          |        19.47 |    33.54 |   43.79 |  +30.57%
  34_startup-totalbytes  |       197.35 |   303.72 |  303.96 |   +0.08%

Workflow: 1020855662
Adding new commits will generate a new report

@github-actions
Copy link

github-actions bot commented Jul 11, 2021 •
edited
Loading 

Finished dev [unoptimized + debuginfo] target(s) in 0.02s
 Running `target/debug/results_diff`

Benchmark Report

  • wasm-bindgen: the performance goal
  • baseline: performance of sycamore-baseline (typically latest master)
  • update: performance of sycamore (typically recent changes)
  • diff: measures the improvement of update over the baseline
@@                         Performance Diff                          @@

##                       | wasm-bindgen | baseline |  update |  diff ##
#######################################################################
- 01_run1k               |       135.33 |   167.78 |  178.18 |   +6.20%
+ 02_replace1k           |       149.93 |   186.08 |  180.40 |   -3.05%
  03_update10th1k_x16    |       251.98 |   272.08 |  268.51 |   -1.31%
+ 04_select1k            |        39.40 |    57.12 |   47.13 |  -17.49%
- 05_swap1k              |        72.36 |    75.52 |   78.54 |   +4.00%
  06_remove-one-1k       |        29.68 |    30.79 |   30.61 |   -0.58%
- 07_create10k           |      1365.70 |  4019.88 | 4439.42 |  +10.44%
- 08_create1k-after1k_x2 |       317.67 |   384.73 |  409.34 |   +6.39%
- 09_clear1k_x8          |       193.42 |   214.88 |  224.82 |   +4.62%
  21_ready-memory        |         1.02 |     1.02 |    1.02 |   +0.00%
  22_run-memory          |         1.50 |     1.80 |    1.78 |   -1.32%
  23_update5-memory      |         1.82 |     2.12 |    2.09 |   -1.13%
  24_run5-memory         |         2.11 |     2.40 |    2.35 |   -1.99%
  25_run-clear-memory    |         2.25 |     2.26 |    2.26 |   +0.11%
  31_startup-ci          |      1928.16 |  1967.50 | 1956.42 |   -0.56%
+ 32_startup-bt          |        22.57 |    41.48 |   36.51 |  -11.99%
  34_startup-totalbytes  |       197.35 |   303.72 |  304.53 |   +0.27%

Workflow: 1020926897
Adding new commits will generate a new report

@github-actions
Copy link

github-actions bot commented Jul 11, 2021 •
edited
Loading 

Finished dev [unoptimized + debuginfo] target(s) in 0.01s
 Running `target/debug/results_diff`

Benchmark Report

  • wasm-bindgen: the performance goal
  • baseline: performance of sycamore-baseline (typically latest master)
  • update: performance of sycamore (typically recent changes)
  • diff: measures the improvement of update over the baseline
@@                         Performance Diff                          @@

##                       | wasm-bindgen | baseline |  update |  diff ##
#######################################################################
- 01_run1k               |       118.96 |   147.95 |  162.04 |   +9.52%
- 02_replace1k           |       128.29 |   153.98 |  157.19 |   +2.08%
- 03_update10th1k_x16    |       193.09 |   197.61 |  220.09 |  +11.38%
- 04_select1k            |        31.38 |    35.25 |   45.54 |  +29.19%
  05_swap1k              |        59.99 |    63.23 |   64.48 |   +1.98%
  06_remove-one-1k       |        24.41 |    24.76 |   24.39 |   -1.49%
- 07_create10k           |      1253.91 |  3492.42 | 3741.12 |   +7.12%
  08_create1k-after1k_x2 |       276.12 |   364.07 |  356.96 |   -1.95%
  09_clear1k_x8          |       186.28 |   194.28 |  195.26 |   +0.50%
  21_ready-memory        |         1.02 |     1.02 |    1.02 |   +0.00%
  22_run-memory          |         1.50 |     1.80 |    1.78 |   -1.32%
  23_update5-memory      |         1.82 |     2.12 |    2.11 |   -0.20%
  24_run5-memory         |         2.11 |     2.40 |    2.35 |   -1.97%
  25_run-clear-memory    |         2.25 |     2.26 |    2.26 |   +0.10%
  31_startup-ci          |      1859.42 |  1994.57 | 1965.89 |   -1.44%
- 32_startup-bt          |        31.58 |    47.33 |   60.71 |  +28.27%
  34_startup-totalbytes  |       197.35 |   303.72 |  304.53 |   +0.27%

Workflow: 1020944019
Adding new commits will generate a new report

@github-actions
Copy link

github-actions bot commented Jul 11, 2021 •
edited
Loading 

Finished dev [unoptimized + debuginfo] target(s) in 0.01s
 Running `target/debug/results_diff`

Benchmark Report

  • wasm-bindgen: the performance goal
  • baseline: performance of sycamore-baseline (typically latest master)
  • update: performance of sycamore (typically recent changes)
  • diff: measures the improvement of update over the baseline
@@                         Performance Diff                          @@

##                       | wasm-bindgen | baseline |  update |  diff ##
#######################################################################
- 01_run1k               |       128.88 |   159.01 |  178.36 |  +12.17%
  02_replace1k           |       142.33 |   172.75 |  172.13 |   -0.36%
- 03_update10th1k_x16    |       217.71 |   242.46 |  249.21 |   +2.78%
- 04_select1k            |        34.41 |    51.86 |   54.75 |   +5.57%
  05_swap1k              |        66.82 |    70.98 |   72.18 |   +1.69%
  06_remove-one-1k       |        28.20 |    28.56 |   29.01 |   +1.56%
- 07_create10k           |      1302.78 |  3762.14 | 4222.34 |  +12.23%
- 08_create1k-after1k_x2 |       291.52 |   368.41 |  380.06 |   +3.16%
  09_clear1k_x8          |       191.39 |   203.13 |  206.85 |   +1.83%
  21_ready-memory        |         1.02 |     1.02 |    1.02 |   +0.00%
  22_run-memory          |         1.50 |     1.78 |    1.78 |   +0.01%
  23_update5-memory      |         1.82 |     2.09 |    2.09 |   -0.00%
+ 24_run5-memory         |         2.11 |     2.40 |    2.35 |   -2.03%
  25_run-clear-memory    |         2.25 |     2.26 |    2.26 |   +0.10%
  31_startup-ci          |      1929.59 |  1966.29 | 1961.27 |   -0.26%
- 32_startup-bt          |        21.02 |    38.23 |   41.12 |   +7.54%
  34_startup-totalbytes  |       197.35 |   303.72 |  304.53 |   +0.27%

Workflow: 1020972487
Adding new commits will generate a new report

@lukechu10 lukechu10 marked this pull request as ready for review July 11, 2021 22:56
@github-actions
Copy link

github-actions bot commented Jul 11, 2021 •
edited
Loading 

Finished dev [unoptimized + debuginfo] target(s) in 0.01s
 Running `target/debug/results_diff`

Benchmark Report

  • wasm-bindgen: the performance goal
  • baseline: performance of sycamore-baseline (typically latest master)
  • update: performance of sycamore (typically recent changes)
  • diff: measures the improvement of update over the baseline
@@                         Performance Diff                          @@

##                       | wasm-bindgen | baseline |  update |  diff ##
#######################################################################
- 01_run1k               |       127.11 |   162.64 |  178.83 |   +9.96%
+ 02_replace1k           |       144.93 |   181.75 |  178.02 |   -2.06%
- 03_update10th1k_x16    |       239.90 |   282.69 |  292.38 |   +3.43%
  04_select1k            |        47.93 |    62.99 |   63.90 |   +1.44%
  05_swap1k              |        74.74 |    80.44 |   79.76 |   -0.84%
  06_remove-one-1k       |        30.60 |    30.44 |   30.61 |   +0.57%
  07_create10k           |      1322.40 |  4174.83 | 4205.03 |   +0.72%
  08_create1k-after1k_x2 |       304.65 |   401.20 |  407.11 |   +1.47%
  09_clear1k_x8          |       199.85 |   214.63 |  211.48 |   -1.47%
  21_ready-memory        |         1.02 |     1.02 |    1.02 |   +0.00%
  22_run-memory          |         1.50 |     1.78 |    1.78 |   +0.00%
  23_update5-memory      |         1.82 |     2.11 |    2.09 |   -0.93%
  24_run5-memory         |         2.11 |     2.40 |    2.35 |   -1.99%
  25_run-clear-memory    |         2.25 |     2.26 |    2.26 |   +0.10%
  31_startup-ci          |      1894.54 |  1960.70 | 1978.98 |   +0.93%
- 32_startup-bt          |        31.56 |    37.45 |   44.80 |  +19.62%
  34_startup-totalbytes  |       197.35 |   303.72 |  304.53 |   +0.27%

Workflow: 1020979778
Adding new commits will generate a new report

@lukechu10 lukechu10 added performance Performance related and removed performance Performance related labels Jul 11, 2021
@github-actions
Copy link

github-actions bot commented Jul 11, 2021 •
edited
Loading 

Finished dev [unoptimized + debuginfo] target(s) in 0.01s
 Running `target/debug/results_diff`

Benchmark Report

  • wasm-bindgen: the performance goal
  • baseline: performance of sycamore-baseline (typically latest master)
  • update: performance of sycamore (typically recent changes)
  • diff: measures the improvement of update over the baseline
@@                         Performance Diff                          @@

##                       | wasm-bindgen | baseline |  update |  diff ##
#######################################################################
- 01_run1k               |       121.41 |   165.69 |  173.38 |   +4.64%
+ 02_replace1k           |       143.08 |   178.29 |  171.71 |   -3.69%
  03_update10th1k_x16    |       225.45 |   261.10 |  260.00 |   -0.42%
- 04_select1k            |        39.01 |    39.75 |   51.49 |  +29.56%
+ 05_swap1k              |        72.04 |    72.14 |   68.88 |   -4.53%
+ 06_remove-one-1k       |        27.72 |    29.27 |   28.23 |   -3.55%
- 07_create10k           |      1257.13 |  3800.87 | 4138.70 |   +8.89%
- 08_create1k-after1k_x2 |       294.81 |   373.98 |  386.93 |   +3.46%
- 09_clear1k_x8          |       174.21 |   204.71 |  210.07 |   +2.62%
  21_ready-memory        |         1.02 |     1.02 |    1.02 |   -0.00%
  22_run-memory          |         1.50 |     1.80 |    1.78 |   -1.33%
  23_update5-memory      |         1.82 |     2.11 |    2.09 |   -1.08%
  24_run5-memory         |         2.11 |     2.40 |    2.35 |   -1.98%
  25_run-clear-memory    |         2.25 |     2.26 |    2.26 |   +0.10%
  31_startup-ci          |      1895.78 |  1963.88 | 1964.72 |   +0.04%
- 32_startup-bt          |        21.94 |    32.18 |   48.62 |  +51.10%
  34_startup-totalbytes  |       197.35 |   303.72 |  304.53 |   +0.27%

Workflow: 1021052837
Adding new commits will generate a new report

@github-actions
Copy link

github-actions bot commented Jul 12, 2021 •
edited
Loading 

Finished dev [unoptimized + debuginfo] target(s) in 0.01s
 Running `target/debug/results_diff`

Benchmark Report

  • wasm-bindgen: the performance goal
  • baseline: performance of sycamore-baseline (typically latest master)
  • update: performance of sycamore (typically recent changes)
  • diff: measures the improvement of update over the baseline
@@                         Performance Diff                          @@

##                       | wasm-bindgen | baseline |  update |  diff ##
#######################################################################
- 01_run1k               |       134.35 |   169.94 |  184.57 |   +8.61%
  02_replace1k           |       152.52 |   182.30 |  183.19 |   +0.48%
  03_update10th1k_x16    |       287.95 |   304.38 |  308.01 |   +1.19%
+ 04_select1k            |        50.46 |    61.40 |   58.81 |   -4.21%
- 05_swap1k              |        76.09 |    82.91 |   85.61 |   +3.26%
  06_remove-one-1k       |        31.26 |    31.31 |   31.76 |   +1.46%
- 07_create10k           |      1330.08 |  3984.28 | 4258.83 |   +6.89%
- 08_create1k-after1k_x2 |       307.71 |   406.34 |  420.47 |   +3.48%
+ 09_clear1k_x8          |       187.69 |   218.72 |  202.40 |   -7.46%
  21_ready-memory        |         1.02 |     1.02 |    1.02 |   +0.00%
  22_run-memory          |         1.50 |     1.80 |    1.78 |   -1.35%
  23_update5-memory      |         1.82 |     2.12 |    2.09 |   -1.14%
  24_run5-memory         |         2.11 |     2.35 |    2.35 |   +0.04%
  25_run-clear-memory    |         2.25 |     2.26 |    2.26 |   +0.10%
  31_startup-ci          |      1896.01 |  1967.31 | 1987.70 |   +1.04%
- 32_startup-bt          |        28.55 |    35.33 |   62.44 |  +76.74%
  34_startup-totalbytes  |       197.35 |   303.72 |  304.53 |   +0.27%

Workflow: 1021192139
Adding new commits will generate a new report

@github-actions
Copy link

github-actions bot commented Jul 12, 2021 •
edited
Loading 

Finished dev [unoptimized + debuginfo] target(s) in 0.01s
 Running `target/debug/results_diff`

Benchmark Report

  • wasm-bindgen: the performance goal
  • baseline: performance of sycamore-baseline (typically latest master)
  • update: performance of sycamore (typically recent changes)
  • diff: measures the improvement of update over the baseline
@@                         Performance Diff                          @@

##                       | wasm-bindgen | baseline |  update |  diff ##
#######################################################################
  01_run1k               |       114.90 |   145.13 |  147.28 |   +1.48%
  02_replace1k           |       128.87 |   152.96 |  154.90 |   +1.27%
+ 03_update10th1k_x16    |       220.41 |   230.57 |  224.03 |   -2.84%
+ 04_select1k            |        33.32 |    48.15 |   44.35 |   -7.88%
  05_swap1k              |        62.18 |    66.20 |   66.12 |   -0.12%
  06_remove-one-1k       |        25.75 |    26.52 |   26.88 |   +1.33%
  07_create10k           |      1171.50 |  3570.11 | 3610.84 |   +1.14%
  08_create1k-after1k_x2 |       256.96 |   344.53 |  341.76 |   -0.80%
- 09_clear1k_x8          |       183.42 |   193.81 |  200.88 |   +3.65%
  21_ready-memory        |         1.02 |     1.02 |    1.02 |   -0.00%
  22_run-memory          |         1.50 |     1.80 |    1.78 |   -1.32%
  23_update5-memory      |         1.82 |     2.12 |    2.09 |   -1.15%
  24_run5-memory         |         2.11 |     2.35 |    2.35 |   +0.05%
  25_run-clear-memory    |         2.25 |     2.26 |    2.26 |   +0.00%
  31_startup-ci          |      1855.57 |  1954.97 | 1956.86 |   +0.10%
- 32_startup-bt          |        24.60 |    39.91 |   42.81 |   +7.27%
  34_startup-totalbytes  |       197.35 |   303.72 |  304.42 |   +0.23%

Workflow: 1024269181
Adding new commits will generate a new report

@github-actions
Copy link

github-actions bot commented Jul 12, 2021 •
edited
Loading 

Finished dev [unoptimized + debuginfo] target(s) in 0.01s
 Running `target/debug/results_diff`

Benchmark Report

  • wasm-bindgen: the performance goal
  • baseline: performance of sycamore-baseline (typically latest master)
  • update: performance of sycamore (typically recent changes)
  • diff: measures the improvement of update over the baseline
@@                         Performance Diff                          @@

##                       | wasm-bindgen | baseline |  update |  diff ##
#######################################################################
+ 01_run1k               |       135.38 |   176.21 |  172.30 |   -2.22%
+ 02_replace1k           |       157.10 |   198.59 |  189.46 |   -4.60%
- 03_update10th1k_x16    |       266.32 |   253.44 |  286.12 |  +12.89%
- 04_select1k            |        43.19 |    48.44 |   61.42 |  +26.79%
- 05_swap1k              |        80.51 |    85.29 |   89.42 |   +4.84%
  06_remove-one-1k       |        33.12 |    33.76 |   34.29 |   +1.58%
  07_create10k           |      1360.90 |  4197.74 | 4217.77 |   +0.48%
  08_create1k-after1k_x2 |       322.90 |   421.69 |  430.12 |   +2.00%
  09_clear1k_x8          |       196.17 |   219.05 |  222.33 |   +1.50%
  21_ready-memory        |         1.02 |     1.02 |    1.02 |   -0.01%
  22_run-memory          |         1.50 |     1.80 |    1.78 |   -1.34%
  23_update5-memory      |         1.82 |     2.12 |    2.11 |   -0.15%
  24_run5-memory         |         2.11 |     2.40 |    2.35 |   -1.98%
  25_run-clear-memory    |         2.25 |     2.26 |    2.26 |   +0.10%
  31_startup-ci          |      1906.12 |  1964.68 | 1960.78 |   -0.20%
- 32_startup-bt          |        42.84 |    42.72 |   60.51 |  +41.64%
  34_startup-totalbytes  |       197.35 |   303.72 |  304.42 |   +0.23%

Workflow: 1024401440
Adding new commits will generate a new report

@lukechu10 lukechu10 merged commit d88683e into master Jul 12, 2021
@lukechu10 lukechu10 deleted the contexts branch July 12, 2021 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-reactivity Area: reactivity and state handling C-enhancement Category: new feature or improvement to existing feature performance Performance related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lukechu10