fix logic error in reconcile_fragments
#180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I noticed when using the `Keyed` component that when the `KeyedProps::iterable` value changed from a large `Vec` to a smaller one containing a subset of the original, not all the obsolete nodes were removed from the DOM. Specifically, I started with a `Vec` with 10 elements, then removed all but the third one. The nodes before the remaining node were removed, but not the ones after it. This patch fixes the problem.
|
Thanks for catching this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed when using the
Keyedcomponent that when theKeyedProps::iterablevalue changed from a large
Vecto a smaller one containing a subset of theoriginal, not all the obsolete nodes were removed from the DOM.
Specifically, I started with a
Vecwith 10 elements, then removed all but thethird one. The nodes before the remaining node were removed, but not the ones
after it. This patch fixes the problem.