Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract reactive primitives into new crate #204

Merged
merged 8 commits into from
Aug 9, 2021
Merged

Conversation

lukechu10
Copy link
Member

No description provided.

@lukechu10 lukechu10 added the A-reactivity Area: reactivity and state handling label Aug 7, 2021
@lukechu10 lukechu10 added the performance Performance related label Aug 8, 2021
@github-actions
Copy link

github-actions bot commented Aug 8, 2021

Finished dev [unoptimized + debuginfo] target(s) in 0.01s
 Running `target/debug/results_diff`

Benchmark Report

  • wasm-bindgen: the performance goal
  • baseline: performance of sycamore-baseline (typically latest master)
  • update: performance of sycamore (typically recent changes)
  • diff: measures the improvement of update over the baseline
@@                         Performance Diff                          @@

##                       | wasm-bindgen | baseline |  update |  diff ##
#######################################################################
  01_run1k               |       111.49 |   147.07 |  145.05 |   -1.37%
  02_replace1k           |       126.35 |   160.11 |  159.01 |   -0.69%
+ 03_update10th1k_x16    |       239.64 |   263.78 |  241.05 |   -8.62%
+ 04_select1k            |        33.92 |    45.44 |   40.62 |  -10.61%
  05_swap1k              |        68.49 |    71.00 |   69.13 |   -2.64%
  06_remove-one-1k       |        24.20 |    25.33 |   24.91 |   -1.63%
  07_create10k           |      1253.71 |  1664.36 | 1665.00 |   +0.04%
  08_create1k-after1k_x2 |       273.93 |   324.71 |  322.75 |   -0.60%
+ 09_clear1k_x8          |       203.51 |   214.57 |  198.53 |   -7.48%
  21_ready-memory        |         1.03 |     1.02 |    1.02 |   -0.00%
  22_run-memory          |         1.51 |     1.81 |    1.81 |   -0.01%
  23_update5-memory      |         1.83 |     2.10 |    2.10 |   -0.00%
  24_run5-memory         |         2.11 |     2.36 |    2.36 |   -0.00%
  25_run-clear-memory    |         2.25 |     2.27 |    2.27 |   +0.00%
- 31_startup-ci          |      1822.74 |  1951.57 | 2022.78 |   +3.65%
+ 32_startup-bt          |        60.05 |   156.95 |  137.24 |  -12.56%
- 34_startup-totalbytes  |       197.35 |   306.68 |  359.09 |  +17.09%

Workflow: 1109070644
Adding new commits will generate a new report

@github-actions
Copy link

github-actions bot commented Aug 8, 2021

Finished dev [unoptimized + debuginfo] target(s) in 0.01s
 Running `target/debug/results_diff`

Benchmark Report

  • wasm-bindgen: the performance goal
  • baseline: performance of sycamore-baseline (typically latest master)
  • update: performance of sycamore (typically recent changes)
  • diff: measures the improvement of update over the baseline
@@                         Performance Diff                          @@

##                       | wasm-bindgen | baseline |  update |  diff ##
#######################################################################
  01_run1k               |       103.16 |   131.66 |  131.59 |   -0.05%
  02_replace1k           |       133.09 |   156.94 |  158.96 |   +1.29%
+ 03_update10th1k_x16    |       303.85 |   334.40 |  321.50 |   -3.86%
- 04_select1k            |        41.75 |    55.14 |   57.02 |   +3.42%
+ 05_swap1k              |        75.34 |    78.48 |   73.27 |   -6.64%
  06_remove-one-1k       |        27.18 |    27.39 |   27.90 |   +1.87%
  07_create10k           |      1093.49 |  1431.85 | 1443.95 |   +0.84%
  08_create1k-after1k_x2 |       247.87 |   306.01 |  304.30 |   -0.56%
- 09_clear1k_x8          |       197.53 |   200.67 |  208.48 |   +3.89%
  21_ready-memory        |         1.03 |     1.02 |    1.02 |   -0.00%
  22_run-memory          |         1.51 |     1.81 |    1.81 |   +0.05%
  23_update5-memory      |         1.83 |     2.10 |    2.10 |   +0.00%
  24_run5-memory         |         2.11 |     2.36 |    2.36 |   -0.00%
  25_run-clear-memory    |         2.25 |     2.27 |    2.27 |   -0.00%
- 31_startup-ci          |      1820.18 |  1958.49 | 2057.93 |   +5.08%
- 32_startup-bt          |        62.25 |    71.89 |  153.08 | +112.92%
- 34_startup-totalbytes  |       197.35 |   306.68 |  359.09 |  +17.09%

Workflow: 1109099012
Adding new commits will generate a new report

@djmitche
Copy link

djmitche commented Aug 8, 2021

Will this crate have a fairly stable API? For example, if I wanted to build a curses frontend with this new crate; or to build a UI for a microcontroller-based device; or maybe build an IoT hub on top of this?

@lukechu10
Copy link
Member Author

lukechu10 commented Aug 8, 2021

@djmitche At the moment, non of the crates have "stable APIs" since we're still at the 0.x stage. However, all the major version numbers are synchronized between the crates so this crate is just as stable as the sycamore crate if you will.

@sycamore-rs sycamore-rs deleted a comment from github-actions bot Aug 9, 2021
@github-actions
Copy link

github-actions bot commented Aug 9, 2021

Finished dev [unoptimized + debuginfo] target(s) in 0.01s
 Running `target/debug/results_diff`

Benchmark Report

  • wasm-bindgen: the performance goal
  • baseline: performance of sycamore-baseline (typically latest master)
  • update: performance of sycamore (typically recent changes)
  • diff: measures the improvement of update over the baseline
@@                         Performance Diff                          @@

##                       | wasm-bindgen | baseline |  update |  diff ##
#######################################################################
  01_run1k               |       103.77 |   129.91 |  127.91 |   -1.54%
  02_replace1k           |       118.57 |   145.86 |  143.83 |   -1.39%
  03_update10th1k_x16    |       268.57 |   275.28 |  272.58 |   -0.98%
- 04_select1k            |        39.43 |    44.32 |   46.66 |   +5.28%
  05_swap1k              |        70.47 |    73.23 |   71.24 |   -2.72%
  06_remove-one-1k       |        25.63 |    26.13 |   26.11 |   -0.05%
  07_create10k           |      1086.06 |  1408.27 | 1416.66 |   +0.60%
  08_create1k-after1k_x2 |       248.21 |   269.57 |  275.89 |   +2.34%
  09_clear1k_x8          |       183.87 |   205.21 |  199.97 |   -2.55%
  21_ready-memory        |         1.03 |     1.02 |    1.02 |   -0.06%
  22_run-memory          |         1.51 |     1.81 |    1.81 |   -0.16%
  23_update5-memory      |         1.83 |     2.10 |    2.10 |   -0.03%
  24_run5-memory         |         2.11 |     2.36 |    2.35 |   -0.03%
  25_run-clear-memory    |         2.25 |     2.27 |    2.27 |   -0.02%
+ 31_startup-ci          |      1819.01 |  2098.77 | 2031.06 |   -3.23%
- 32_startup-bt          |        57.20 |    98.31 |  113.31 |  +15.26%
  34_startup-totalbytes  |       197.35 |   306.68 |  310.99 |   +1.41%

Workflow: 1111125523
Adding new commits will generate a new report

@lukechu10 lukechu10 merged commit 0eb84ca into master Aug 9, 2021
@lukechu10 lukechu10 deleted the reactive-perf branch August 9, 2021 00:36
@lukechu10 lukechu10 added the BREAKING CHANGE Breaking changes introduced in this PR label Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-reactivity Area: reactivity and state handling BREAKING CHANGE Breaking changes introduced in this PR performance Performance related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants