Explain that Trunk needs a HTML source file #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi! Just exploring Sycamore (looks cool so far) and ran into trouble running the hello world example, which doesn't describe creating index.html, which Trunk needs. Following the current instructions gives an error:
```shell
$ trunk serve
Error: error getting canonical path to source HTML file "index.html"
Caused by:
No such file or directory (os error 2)
```
So I thought I'd fix that :)
The page in question also previously said:
> In fact, the Hello World program in Sycamore is but slightly longer than the console version!
But the console version is not described. So I've removed this sentence.
Finally, the description of the sycamore repo on Github is
> A reactive DOM library for Rust in WASM
I only mention this in case you wanted to update it to "Sycamore is a modern VDOM-less web library with fine-grained reactivity in Rust and WebAssembly." to match the readme.
Thanks!
|
LGTM. There definitely needs some consistency between the Sycamore taglines. Maybe "blazing-fast Rust library for creating web applications (with WebAssembly)" or something of the like. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! Just exploring Sycamore (looks cool so far) and ran into trouble running the hello world example, which doesn't describe creating index.html, which Trunk needs. Following the current instructions gives an error:
So I thought I'd fix that :)
The page in question also previously said:
But the console version is not described. So I've removed this sentence.
Finally, the description of the sycamore repo on Github is
I only mention this in case you wanted to update it to "Sycamore is a modern VDOM-less web library with fine-grained reactivity in Rust and WebAssembly." to match the readme.
Thanks!