Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize create_effect #216

Merged
merged 3 commits into from
Aug 29, 2021
Merged

Optimize create_effect #216

merged 3 commits into from
Aug 29, 2021

Conversation

lukechu10
Copy link
Member

No description provided.

@lukechu10 lukechu10 added the performance Performance related label Aug 29, 2021
@github-actions
Copy link

github-actions bot commented Aug 29, 2021

Finished dev [unoptimized + debuginfo] target(s) in 0.01s
 Running `target/debug/results_diff`

Benchmark Report

  • wasm-bindgen: the performance goal
  • baseline: performance of sycamore-baseline (typically latest master)
  • update: performance of sycamore (typically recent changes)
  • diff: measures the improvement of update over the baseline
@@                         Performance Diff                          @@

##                       | wasm-bindgen | baseline |  update |  diff ##
#######################################################################
- 01_run1k               |       104.59 |   116.58 |  126.55 |   +8.55%
  02_replace1k           |       121.52 |   135.54 |  136.72 |   +0.87%
- 03_update10th1k_x16    |       296.19 |   302.04 |  326.22 |   +8.00%
+ 04_select1k            |        42.41 |    55.34 |   47.10 |  -14.88%
+ 05_swap1k              |        72.81 |    76.90 |   71.27 |   -7.32%
  06_remove-one-1k       |        25.43 |    26.46 |   26.00 |   -1.73%
+ 07_create10k           |      1062.73 |  1412.39 | 1350.41 |   -4.39%
+ 08_create1k-after1k_x2 |       249.27 |   282.13 |  264.74 |   -6.16%
+ 09_clear1k_x8          |       189.62 |   201.46 |  183.80 |   -8.77%
  21_ready-memory        |         1.03 |     1.02 |    1.02 |   +0.00%
  22_run-memory          |         1.51 |     1.84 |    1.84 |   +0.01%
  23_update5-memory      |         1.83 |     2.13 |    2.12 |   -0.00%
  24_run5-memory         |         2.11 |     2.37 |    2.37 |   -0.00%
  25_run-clear-memory    |         2.26 |     2.29 |    2.29 |   -0.00%
  31_startup-ci          |      1858.80 |  1965.60 | 1944.26 |   -1.09%
+ 32_startup-bt          |        49.59 |    97.89 |   69.76 |  -28.74%
+ 34_startup-totalbytes  |       197.35 |   344.25 |  296.17 |  -13.97%

Workflow: 1178381636
Adding new commits will generate a new report

@lukechu10 lukechu10 added performance Performance related and removed performance Performance related labels Aug 29, 2021
@github-actions
Copy link

github-actions bot commented Aug 29, 2021

Finished dev [unoptimized + debuginfo] target(s) in 0.01s
 Running `target/debug/results_diff`

Benchmark Report

  • wasm-bindgen: the performance goal
  • baseline: performance of sycamore-baseline (typically latest master)
  • update: performance of sycamore (typically recent changes)
  • diff: measures the improvement of update over the baseline
@@                         Performance Diff                          @@

##                       | wasm-bindgen | baseline |  update |  diff ##
#######################################################################
- 01_run1k               |       111.24 |   140.56 |  146.30 |   +4.09%
- 02_replace1k           |       130.92 |   153.09 |  161.53 |   +5.51%
- 03_update10th1k_x16    |       313.88 |   319.44 |  357.07 |  +11.78%
  04_select1k            |        52.33 |    56.91 |   57.36 |   +0.79%
  05_swap1k              |        82.58 |    87.14 |   84.63 |   -2.88%
- 06_remove-one-1k       |        28.47 |    27.94 |   28.82 |   +3.16%
  07_create10k           |      1113.17 |  1465.40 | 1434.77 |   -2.09%
  08_create1k-after1k_x2 |       264.61 |   301.88 |  309.31 |   +2.46%
+ 09_clear1k_x8          |       184.44 |   201.01 |  193.24 |   -3.86%
  21_ready-memory        |         1.03 |     1.02 |    1.02 |   -0.00%
  22_run-memory          |         1.51 |     1.84 |    1.84 |   -0.00%
  23_update5-memory      |         1.83 |     2.13 |    2.13 |   +0.00%
  24_run5-memory         |         2.11 |     2.37 |    2.37 |   -0.00%
  25_run-clear-memory    |         2.25 |     2.29 |    2.29 |   -0.00%
  31_startup-ci          |      1851.03 |  1899.57 | 1891.49 |   -0.43%
- 32_startup-bt          |        38.43 |    82.96 |  190.11 | +129.17%
+ 34_startup-totalbytes  |       197.35 |   344.25 |  296.17 |  -13.97%

Workflow: 1178412156
Adding new commits will generate a new report

@github-actions
Copy link

github-actions bot commented Aug 29, 2021

Finished dev [unoptimized + debuginfo] target(s) in 0.01s
 Running `target/debug/results_diff`

Benchmark Report

  • wasm-bindgen: the performance goal
  • baseline: performance of sycamore-baseline (typically latest master)
  • update: performance of sycamore (typically recent changes)
  • diff: measures the improvement of update over the baseline
@@                         Performance Diff                          @@

##                       | wasm-bindgen | baseline |  update |  diff ##
#######################################################################
- 01_run1k               |        96.08 |   125.73 |  138.25 |   +9.96%
- 02_replace1k           |       114.00 |   136.75 |  157.48 |  +15.16%
- 03_update10th1k_x16    |       257.66 |   271.75 |  318.25 |  +17.11%
+ 04_select1k            |        33.53 |    44.85 |   40.30 |  -10.15%
  05_swap1k              |        69.12 |    73.64 |   72.35 |   -1.76%
  06_remove-one-1k       |        25.73 |    25.67 |   25.46 |   -0.81%
  07_create10k           |      1002.25 |  1314.68 | 1342.64 |   +2.13%
  08_create1k-after1k_x2 |       235.66 |   272.71 |  278.19 |   +2.01%
  09_clear1k_x8          |       180.77 |   192.60 |  194.18 |   +0.82%
  21_ready-memory        |         1.03 |     1.02 |    1.02 |   +0.00%
  22_run-memory          |         1.51 |     1.84 |    1.84 |   +0.02%
  23_update5-memory      |         1.83 |     2.13 |    2.13 |   -0.00%
  24_run5-memory         |         2.11 |     2.37 |    2.37 |   -0.00%
  25_run-clear-memory    |         2.25 |     2.29 |    2.29 |   +0.00%
  31_startup-ci          |      1858.67 |  2024.94 | 1978.25 |   -2.31%
- 32_startup-bt          |        60.16 |   118.29 |  125.79 |   +6.34%
+ 34_startup-totalbytes  |       197.35 |   344.25 |  296.53 |  -13.86%

Workflow: 1178427835
Adding new commits will generate a new report

@github-actions
Copy link

github-actions bot commented Aug 29, 2021

Finished dev [unoptimized + debuginfo] target(s) in 0.01s
 Running `target/debug/results_diff`

Benchmark Report

  • wasm-bindgen: the performance goal
  • baseline: performance of sycamore-baseline (typically latest master)
  • update: performance of sycamore (typically recent changes)
  • diff: measures the improvement of update over the baseline
@@                         Performance Diff                          @@

##                       | wasm-bindgen | baseline |  update |  diff ##
#######################################################################
- 01_run1k               |       121.91 |   155.63 |  164.79 |   +5.89%
  02_replace1k           |       145.13 |   175.14 |  176.18 |   +0.60%
- 03_update10th1k_x16    |       349.35 |   358.27 |  390.52 |   +9.00%
- 04_select1k            |        53.32 |    52.19 |   54.82 |   +5.04%
  05_swap1k              |        87.33 |    90.18 |   91.36 |   +1.31%
+ 06_remove-one-1k       |        31.58 |    33.13 |   31.95 |   -3.57%
  07_create10k           |      1255.48 |  1692.54 | 1694.29 |   +0.10%
  08_create1k-after1k_x2 |       312.71 |   350.89 |  343.78 |   -2.02%
+ 09_clear1k_x8          |       215.80 |   237.18 |  229.02 |   -3.44%
  21_ready-memory        |         1.03 |     1.02 |    1.02 |   -0.01%
  22_run-memory          |         1.51 |     1.84 |    1.84 |   +0.02%
  23_update5-memory      |         1.83 |     2.12 |    2.12 |   -0.00%
  24_run5-memory         |         2.11 |     2.37 |    2.37 |   +0.00%
  25_run-clear-memory    |         2.25 |     2.29 |    2.29 |   -0.00%
  31_startup-ci          |      1859.98 |  1990.58 | 1974.40 |   -0.81%
+ 32_startup-bt          |        64.85 |   106.77 |   97.25 |   -8.92%
+ 34_startup-totalbytes  |       197.35 |   344.25 |  296.17 |  -13.97%

Workflow: 1178445244
Adding new commits will generate a new report

@lukechu10 lukechu10 merged commit a5e05f6 into master Aug 29, 2021
@lukechu10 lukechu10 deleted the effect-opt branch August 29, 2021 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance Performance related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant