Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SsrNode remove_child #218

Merged
merged 2 commits into from
Aug 29, 2021
Merged

Fix SsrNode remove_child #218

merged 2 commits into from
Aug 29, 2021

Conversation

lukechu10
Copy link
Member

remove_child used to remove all nodes instead of only the specified node.

Added some regression tests.

@lukechu10 lukechu10 added C-bug Category: bug, something isn't working A-SSR Area: Server Side Rendering (SSR) and Static Site Generation (SSG) labels Aug 29, 2021
@lukechu10 lukechu10 merged commit d52bc9b into master Aug 29, 2021
@lukechu10 lukechu10 deleted the fix-ssr branch August 29, 2021 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-SSR Area: Server Side Rendering (SSR) and Static Site Generation (SSG) C-bug Category: bug, something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant