Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use unwrap_throw instead of unwrap #226

Merged
merged 4 commits into from
Sep 8, 2021
Merged

Use unwrap_throw instead of unwrap #226

merged 4 commits into from
Sep 8, 2021

Conversation

lukechu10
Copy link
Member

No description provided.

@lukechu10 lukechu10 added the performance Performance related label Sep 7, 2021
@github-actions
Copy link

github-actions bot commented Sep 7, 2021 •
edited
Loading 

Finished dev [unoptimized + debuginfo] target(s) in 0.01s
 Running `target/debug/results_diff`

Benchmark Report

  • wasm-bindgen: the performance goal
  • baseline: performance of sycamore-baseline (typically latest master)
  • update: performance of sycamore (typically recent changes)
  • diff: measures the improvement of update over the baseline
@@                         Performance Diff                          @@

##                       | wasm-bindgen | baseline |  update |  diff ##
#######################################################################
  01_run1k               |       123.48 |   158.89 |  163.03 |   +2.61%
  02_replace1k           |       150.46 |   175.36 |  178.90 |   +2.02%
  03_update10th1k_x16    |       331.86 |   362.69 |  369.91 |   +1.99%
- 04_select1k            |        50.80 |    56.62 |   58.42 |   +3.19%
+ 05_swap1k              |        83.55 |    89.81 |   86.95 |   -3.19%
  06_remove-one-1k       |        30.48 |    31.61 |   31.67 |   +0.19%
  07_create10k           |      1241.72 |  1620.79 | 1617.51 |   -0.20%
  08_create1k-after1k_x2 |       301.82 |   337.69 |  332.58 |   -1.51%
  09_clear1k_x8          |       205.96 |   222.94 |  221.41 |   -0.69%
  21_ready-memory        |         1.03 |     1.02 |    1.02 |   -0.01%
  22_run-memory          |         1.51 |     1.84 |    1.84 |   -0.00%
  23_update5-memory      |         1.83 |     2.12 |    2.12 |   -0.00%
  24_run5-memory         |         2.11 |     2.37 |    2.37 |   -0.00%
  25_run-clear-memory    |         2.25 |     2.29 |    2.29 |   -0.01%
+ 31_startup-ci          |      1884.21 |  2044.65 | 1930.09 |   -5.60%
- 32_startup-bt          |        59.11 |    89.02 |  143.55 |  +61.26%
  34_startup-totalbytes  |       197.35 |   344.37 |  342.57 |   -0.52%

Workflow: 1210312640
Adding new commits will generate a new report

@github-actions
Copy link

github-actions bot commented Sep 8, 2021 •
edited
Loading 

Finished dev [unoptimized + debuginfo] target(s) in 0.01s
 Running `target/debug/results_diff`

Benchmark Report

  • wasm-bindgen: the performance goal
  • baseline: performance of sycamore-baseline (typically latest master)
  • update: performance of sycamore (typically recent changes)
  • diff: measures the improvement of update over the baseline
@@                         Performance Diff                          @@

##                       | wasm-bindgen | baseline |  update |  diff ##
#######################################################################
  01_run1k               |       105.41 |   136.67 |  135.10 |   -1.15%
  02_replace1k           |       124.10 |   151.85 |  155.33 |   +2.29%
  03_update10th1k_x16    |       297.59 |   309.33 |  310.19 |   +0.28%
+ 04_select1k            |        40.09 |    52.19 |   45.34 |  -13.12%
  05_swap1k              |        75.47 |    76.70 |   76.37 |   -0.43%
  06_remove-one-1k       |        27.22 |    27.75 |   27.45 |   -1.09%
  07_create10k           |      1080.93 |  1419.85 | 1413.10 |   -0.48%
  08_create1k-after1k_x2 |       257.65 |   290.16 |  287.68 |   -0.86%
  09_clear1k_x8          |       190.71 |   197.86 |  201.48 |   +1.83%
  21_ready-memory        |         1.03 |     1.02 |    1.02 |   -0.01%
  22_run-memory          |         1.51 |     1.84 |    1.84 |   -0.02%
  23_update5-memory      |         1.83 |     2.12 |    2.12 |   -0.00%
  24_run5-memory         |         2.11 |     2.37 |    2.37 |   +0.00%
  25_run-clear-memory    |         2.25 |     2.29 |    2.29 |   +0.00%
+ 31_startup-ci          |      1939.25 |  2079.05 | 2000.44 |   -3.78%
- 32_startup-bt          |        43.99 |    96.10 |  132.18 |  +37.54%
  34_startup-totalbytes  |       197.35 |   344.37 |  342.57 |   -0.52%

Workflow: 1211469841
Adding new commits will generate a new report

@github-actions
Copy link

github-actions bot commented Sep 8, 2021 •
edited
Loading 

Finished dev [unoptimized + debuginfo] target(s) in 0.01s
 Running `target/debug/results_diff`

Benchmark Report

  • wasm-bindgen: the performance goal
  • baseline: performance of sycamore-baseline (typically latest master)
  • update: performance of sycamore (typically recent changes)
  • diff: measures the improvement of update over the baseline
@@                         Performance Diff                          @@

##                       | wasm-bindgen | baseline |  update |  diff ##
#######################################################################
  01_run1k               |       134.30 |   161.79 |  161.99 |   +0.12%
  02_replace1k           |       145.35 |   178.75 |  182.76 |   +2.25%
- 03_update10th1k_x16    |       327.27 |   312.04 |  375.82 |  +20.44%
  04_select1k            |        40.65 |    47.59 |   47.73 |   +0.29%
+ 05_swap1k              |        78.53 |    85.58 |   80.95 |   -5.41%
  06_remove-one-1k       |        27.90 |    29.06 |   28.72 |   -1.16%
  07_create10k           |      1409.18 |  1897.98 | 1865.68 |   -1.70%
  08_create1k-after1k_x2 |       320.21 |   370.76 |  366.07 |   -1.27%
- 09_clear1k_x8          |       220.19 |   229.87 |  237.53 |   +3.33%
  21_ready-memory        |         1.03 |     1.02 |    1.02 |   -0.02%
  22_run-memory          |         1.51 |     1.84 |    1.84 |   -0.01%
  23_update5-memory      |         1.83 |     2.13 |    2.12 |   -0.01%
  24_run5-memory         |         2.11 |     2.37 |    2.37 |   +0.03%
  25_run-clear-memory    |         2.25 |     2.29 |    2.29 |   -0.01%
  31_startup-ci          |      1861.84 |  2066.69 | 2072.75 |   +0.29%
- 32_startup-bt          |        61.10 |    99.73 |  113.10 |  +13.41%
  34_startup-totalbytes  |       197.35 |   344.37 |  342.57 |   -0.52%

Workflow: 1211813931
Adding new commits will generate a new report

@github-actions
Copy link

github-actions bot commented Sep 8, 2021 •
edited
Loading 

Finished dev [unoptimized + debuginfo] target(s) in 0.01s
 Running `target/debug/results_diff`

Benchmark Report

  • wasm-bindgen: the performance goal
  • baseline: performance of sycamore-baseline (typically latest master)
  • update: performance of sycamore (typically recent changes)
  • diff: measures the improvement of update over the baseline
@@                         Performance Diff                          @@

##                       | wasm-bindgen | baseline |  update |  diff ##
#######################################################################
- 01_run1k               |       123.73 |   152.08 |  159.41 |   +4.82%
- 02_replace1k           |       134.62 |   164.48 |  174.47 |   +6.07%
- 03_update10th1k_x16    |       277.29 |   310.46 |  363.92 |  +17.22%
- 04_select1k            |        36.18 |    48.90 |   52.71 |   +7.79%
+ 05_swap1k              |        74.27 |    78.15 |   74.46 |   -4.71%
+ 06_remove-one-1k       |        25.83 |    27.01 |   25.65 |   -5.07%
  07_create10k           |      1317.61 |  1719.88 | 1700.01 |   -1.16%
  08_create1k-after1k_x2 |       291.66 |   348.30 |  348.17 |   -0.04%
+ 09_clear1k_x8          |       200.41 |   239.05 |  208.60 |  -12.74%
  21_ready-memory        |         1.03 |     1.02 |    1.02 |   -0.01%
  22_run-memory          |         1.51 |     1.84 |    1.84 |   -0.01%
  23_update5-memory      |         1.83 |     2.13 |    2.12 |   -0.00%
  24_run5-memory         |         2.11 |     2.37 |    2.37 |   +0.03%
  25_run-clear-memory    |         2.25 |     2.29 |    2.29 |   -0.01%
+ 31_startup-ci          |      1908.43 |  2191.54 | 2021.12 |   -7.78%
+ 32_startup-bt          |        92.53 |   111.23 |   97.61 |  -12.24%
  34_startup-totalbytes  |       197.35 |   344.37 |  342.50 |   -0.54%

Workflow: 1211860356
Adding new commits will generate a new report

@lukechu10 lukechu10 merged commit fc640d3 into master Sep 8, 2021
@lukechu10 lukechu10 deleted the unwrap-throw branch September 8, 2021 03:32
@lukechu10 lukechu10 restored the unwrap-throw branch September 8, 2021 03:32
@lukechu10 lukechu10 deleted the unwrap-throw branch September 8, 2021 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
performance Performance related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lukechu10