render_temporarily_to() helper #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukechu10
reviewed
Nov 23, 2021
| /// | ||
| /// _This API requires the following crate features to be activated: `dom`_ | ||
| #[must_use = "please hold onto the ReactiveScope until you want to clean things up, or use render_to() instead"] | ||
| pub fn render_temporarily_to( |
There was a problem hiding this comment.
I'm not sure this is the right name to use here. How about something like render_get_scope?
There was a problem hiding this comment.
I have pushed a change to use render_get_scope.
Other potential names include render_and_get_scope render_and_return_scope render_to_scope mount_and_get_scope. Shout if you prefer any of those.
|
lgtm. thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I mentioned in https://discord.com/channels/820400041332179004/821489793258487839/912364912624418846 I was having problems with things not getting dropped when gradually converting an existing app to use sycamore.
This function is intended to be used for injecting an ephemeral sycamore view into a non-sycamore app
(for example, a file upload modal where you want to cancel the upload if the modal is closed).
You should only use this function while refactoring your app, and you should aim to have a single
call to [
render] or [render_to] at the top level of your app long-term.Using this function did solve my problems.