Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parenthesizing of expressions in view! interpolation syntax #304

Merged
merged 1 commit into from
Nov 26, 2021

Conversation

lukechu10
Copy link
Member

Fixes #262

Adds an extra (...) around #splice in packages/sycamore-macro/src/view/element.rs to make sure whole expression is borrowed.

@lukechu10 lukechu10 added C-bug Category: bug, something isn't working A-macro Area: macros A-view Area: view! macro labels Nov 26, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #304 (0bf498e) into master (6b739b8) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #304   +/-   ##
=======================================
  Coverage   72.70%   72.70%           
=======================================
  Files          38       38           
  Lines        5143     5143           
=======================================
  Hits         3739     3739           
  Misses       1404     1404           
Impacted Files Coverage Δ
packages/sycamore-macro/src/view/element.rs 96.36% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b739b8...0bf498e. Read the comment docs.

@lukechu10 lukechu10 merged commit 31050ae into master Nov 26, 2021
@lukechu10 lukechu10 deleted the fix-interpolation-paren branch November 26, 2021 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-macro Area: macros A-view Area: view! macro C-bug Category: bug, something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong borrowing of expression in template!
2 participants