Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better debugging for ReactiveScopes #307

Merged
merged 5 commits into from
Nov 30, 2021
Merged

Better debugging for ReactiveScopes #307

merged 5 commits into from
Nov 30, 2021

Conversation

lukechu10
Copy link
Member

No description provided.

@lukechu10 lukechu10 added A-reactivity Area: reactivity and state handling A-ergonomics Area: API ergonomics labels Nov 29, 2021
@codecov-commenter
Copy link

codecov-commenter commented Nov 29, 2021

Codecov Report

Merging #307 (209b1a1) into master (4663c7c) will decrease coverage by 0.36%.
The diff coverage is 52.38%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #307      +/-   ##
==========================================
- Coverage   72.71%   72.34%   -0.37%     
==========================================
  Files          38       38              
  Lines        5146     5222      +76     
==========================================
+ Hits         3742     3778      +36     
- Misses       1404     1444      +40     
Impacted Files Coverage Δ
packages/sycamore-macro/src/lib.rs 75.00% <ø> (ø)
packages/sycamore/src/context.rs 100.00% <ø> (ø)
packages/sycamore-reactive/src/effect.rs 87.94% <32.00%> (-4.15%) ⬇️
packages/sycamore-reactive/src/context.rs 80.00% <62.50%> (-9.19%) ⬇️
packages/sycamore-macro/src/component/mod.rs 75.47% <100.00%> (+1.60%) ⬆️
packages/sycamore-reactive/src/lib.rs 94.02% <100.00%> (+0.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4663c7c...209b1a1. Read the comment docs.

@lukechu10 lukechu10 merged commit 16ff0a9 into master Nov 30, 2021
@lukechu10 lukechu10 deleted the debug-scopes branch November 30, 2021 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ergonomics Area: API ergonomics A-reactivity Area: reactivity and state handling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants