Remove double-boxing of Computation #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh no, CI failed because I don't have permission to push to GH pages. Is there a way to fix that? |
lukechu10
added a commit
that referenced
this pull request
Mar 10, 2021
* Refactor Signal Make Signal a normal struct rather than a tuple struct * Rename Computation to Callback * Rename DEPENDENCIES to CONTEXT * Do not trigger build_docs on pull_request * Use a trait object to store dependencies * Rename CONTEXT to RUNNING * Move subscribe closure into subscribe_callback * Build on push * Make CONTEXTS a Vec stack * Add (ignored) test for effect dynamic dependencies * Get rid of execute() * Store effect state in Running * Add cleanup function * wip * wip * Replace Box with Rc * Replace Vec with HashSet * Make dependency use a HashSet * Add doc comment to cleanup_running * Squashed commit of the following: commit b61242a Author: Luke Chu <37006668+lukechu10@users.noreply.github.com> Date: Tue Mar 9 22:14:18 2021 -0800 Create CODE_OF_CONDUCT.md (#33) commit e5dddbc Author: Kestrer <kestrer.dev@gmail.com> Date: Tue Mar 9 18:44:56 2021 +0000 Remove double-boxing of Computation (#31) * Refactor create_effect_initial to recreate dependencies * Refactor create_effect using create_effect_initial
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Computationpreviously had two boxes (or well box-likes) as it was essentially anRc<Box<dyn Fn()>>- so I replaced this with just anRc<dyn Fn()>. Additionally, I switched from aVec<Rc<Computation>>to aHashSet<Computation>, which should allowobserveto become a constant-time instead of linear-time operation.