Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix contexts inside effects #310

Merged
merged 8 commits into from
Dec 1, 2021
Merged

Fix contexts inside effects #310

merged 8 commits into from
Dec 1, 2021

Conversation

lukechu10
Copy link
Member

@lukechu10 lukechu10 commented Nov 30, 2021

Fixes #308

@lukechu10 lukechu10 added C-bug Category: bug, something isn't working A-context labels Nov 30, 2021
@codecov-commenter
Copy link

codecov-commenter commented Nov 30, 2021

Codecov Report

Merging #310 (c6a31b9) into master (eda8536) will increase coverage by 0.86%.
The diff coverage is 93.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #310      +/-   ##
==========================================
+ Coverage   72.34%   73.21%   +0.86%     
==========================================
  Files          38       38              
  Lines        5222     5313      +91     
==========================================
+ Hits         3778     3890     +112     
+ Misses       1444     1423      -21     
Impacted Files Coverage Δ
packages/sycamore/src/view.rs 66.03% <ø> (ø)
packages/sycamore-reactive/src/effect.rs 91.04% <86.11%> (+3.09%) ⬆️
packages/sycamore-reactive/src/lib.rs 95.77% <88.88%> (+1.74%) ⬆️
packages/sycamore/src/context.rs 99.10% <98.30%> (-0.90%) ⬇️
packages/sycamore-reactive/src/context.rs 82.00% <100.00%> (+2.00%) ⬆️
packages/sycamore-reactive/src/iter.rs 97.81% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eda8536...c6a31b9. Read the comment docs.

@lukechu10 lukechu10 added the A-reactivity Area: reactivity and state handling label Nov 30, 2021
@lukechu10 lukechu10 marked this pull request as ready for review December 1, 2021 05:53
@lukechu10 lukechu10 merged commit 36d4a29 into master Dec 1, 2021
@lukechu10 lukechu10 deleted the fix-contexts branch December 1, 2021 05:54
@lukechu10 lukechu10 added the BREAKING CHANGE Breaking changes introduced in this PR label Dec 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-reactivity Area: reactivity and state handling BREAKING CHANGE Breaking changes introduced in this PR C-bug Category: bug, something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Panic: 'context not found for type'
2 participants