Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suspense with first class async/await support #345

Merged
merged 6 commits into from
Feb 5, 2022
Merged

Suspense with first class async/await support #345

merged 6 commits into from
Feb 5, 2022

Conversation

lukechu10
Copy link
Member

No description provided.

@lukechu10 lukechu10 added C-enhancement Category: new feature or improvement to existing feature A-ergonomics Area: API ergonomics labels Feb 4, 2022
@codecov-commenter
Copy link

codecov-commenter commented Feb 4, 2022

Codecov Report

Merging #345 (f777fe7) into master (de89dab) will decrease coverage by 0.38%.
The diff coverage is 48.27%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #345      +/-   ##
==========================================
- Coverage   64.44%   64.06%   -0.39%     
==========================================
  Files          46       49       +3     
  Lines        7004     7152     +148     
==========================================
+ Hits         4514     4582      +68     
- Misses       2490     2570      +80     
Impacted Files Coverage Δ
packages/sycamore/src/component.rs 30.00% <0.00%> (-1.04%) ⬇️
packages/sycamore/src/context.rs 0.00% <0.00%> (ø)
packages/sycamore/src/futures.rs 0.00% <ø> (ø)
packages/sycamore/src/lib.rs 100.00% <ø> (ø)
packages/sycamore/src/suspense.rs 0.00% <0.00%> (ø)
packages/sycamore-futures/src/lib.rs 3.70% <3.70%> (ø)
packages/sycamore-macro/src/component/mod.rs 73.13% <93.93%> (+15.80%) ⬆️
docs/build.rs 98.59% <100.00%> (ø)
packages/sycamore-macro/src/view/codegen.rs 95.84% <100.00%> (+0.03%) ⬆️
packages/sycamore-reactive/src/effect.rs 99.33% <100.00%> (+<0.01%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de89dab...f777fe7. Read the comment docs.

@lukechu10 lukechu10 marked this pull request as ready for review February 5, 2022 22:54
@lukechu10 lukechu10 merged commit 194d462 into master Feb 5, 2022
@lukechu10 lukechu10 deleted the suspense branch February 5, 2022 23:54
@lukechu10 lukechu10 added the A-async Area: futures, suspense, and async/await label Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-async Area: futures, suspense, and async/await A-ergonomics Area: API ergonomics C-enhancement Category: new feature or improvement to existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants