Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transitions #353

Merged
merged 9 commits into from
Feb 8, 2022
Merged

Transitions #353

merged 9 commits into from
Feb 8, 2022

Conversation

lukechu10
Copy link
Member

No description provided.

@lukechu10 lukechu10 added A-ergonomics Area: API ergonomics A-async Area: futures, suspense, and async/await labels Feb 8, 2022
@codecov-commenter
Copy link

codecov-commenter commented Feb 8, 2022

Codecov Report

Merging #353 (67c14e2) into master (ab3e5b0) will decrease coverage by 0.01%.
The diff coverage is 84.87%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #353      +/-   ##
==========================================
- Coverage   66.07%   66.05%   -0.02%     
==========================================
  Files          49       48       -1     
  Lines        7254     7294      +40     
==========================================
+ Hits         4793     4818      +25     
- Misses       2461     2476      +15     
Impacted Files Coverage Δ
packages/sycamore/src/flow.rs 41.17% <ø> (ø)
packages/sycamore/src/futures.rs 0.00% <ø> (ø)
packages/sycamore/src/generic_node/mod.rs 100.00% <ø> (ø)
packages/sycamore/src/lib.rs 100.00% <ø> (ø)
packages/sycamore-macro/src/lib.rs 64.51% <41.66%> (-16.44%) ⬇️
packages/sycamore/src/suspense.rs 91.17% <88.29%> (-7.73%) ⬇️
packages/sycamore-macro/src/component/mod.rs 72.72% <100.00%> (-0.41%) ⬇️
packages/sycamore-macro/src/view/codegen.rs 95.84% <100.00%> (ø)
packages/sycamore-reactive/src/context.rs 81.35% <100.00%> (+3.57%) ⬆️
packages/sycamore/src/component.rs 63.33% <100.00%> (-10.01%) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab3e5b0...67c14e2. Read the comment docs.

@lukechu10 lukechu10 marked this pull request as ready for review February 8, 2022 22:59
@lukechu10 lukechu10 merged commit 923c23c into master Feb 8, 2022
@lukechu10 lukechu10 deleted the transitions branch February 8, 2022 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-async Area: futures, suspense, and async/await A-ergonomics Area: API ergonomics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants