Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify SsrNode and HydrateNode codegen in view! macro #392

Merged
merged 4 commits into from
Mar 19, 2022

Conversation

lukechu10
Copy link
Member

@lukechu10 lukechu10 commented Mar 19, 2022

Fixes exponential code generation when using SSR and hydration with the view! macro.
Also fixes hydration errors related to the fact that code in client side is not executed in the same order as on the server side.

@lukechu10 lukechu10 added A-macro Area: macros A-view Area: view! macro labels Mar 19, 2022
@codecov
Copy link

codecov bot commented Mar 19, 2022

Codecov Report

Merging #392 (b744aa7) into master (48bdd72) will decrease coverage by 0.05%.
The diff coverage is 79.31%.

@@            Coverage Diff             @@
##           master     #392      +/-   ##
==========================================
- Coverage   63.18%   63.12%   -0.06%     
==========================================
  Files          47       48       +1     
  Lines        7735     7750      +15     
==========================================
+ Hits         4887     4892       +5     
- Misses       2848     2858      +10     
Impacted Files Coverage Δ
packages/sycamore/src/utils/mod.rs 33.33% <33.33%> (ø)
packages/sycamore-macro/src/view/codegen.rs 96.25% <100.00%> (+0.26%) ⬆️
website/src/main.rs 0.58% <0.00%> (-0.02%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48bdd72...b744aa7. Read the comment docs.

@lukechu10 lukechu10 merged commit fde706a into master Mar 19, 2022
@lukechu10 lukechu10 deleted the simplify-hydrate-codegen branch March 19, 2022 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-macro Area: macros A-view Area: view! macro
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant