Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support setting class on SVG elements #398

Merged
merged 1 commit into from
Mar 21, 2022
Merged

Support setting class on SVG elements #398

merged 1 commit into from
Mar 21, 2022

Conversation

lukechu10
Copy link
Member

Fixes #391

@lukechu10 lukechu10 added C-bug Category: bug, something isn't working A-svg Area: SVG support labels Mar 21, 2022
@codecov
Copy link

codecov bot commented Mar 21, 2022

Codecov Report

Merging #398 (3a65c9a) into master (a3bc95c) will decrease coverage by 0.10%.
The diff coverage is 7.14%.

@@            Coverage Diff             @@
##           master     #398      +/-   ##
==========================================
- Coverage   63.21%   63.10%   -0.11%     
==========================================
  Files          48       48              
  Lines        7742     7749       +7     
==========================================
- Hits         4894     4890       -4     
- Misses       2848     2859      +11     
Impacted Files Coverage Δ
packages/sycamore-reactive/src/signal.rs 85.19% <ø> (ø)
packages/sycamore/src/generic_node/dom_node.rs 0.00% <0.00%> (ø)
packages/sycamore-macro/src/view/codegen.rs 96.23% <100.00%> (-0.04%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3bc95c...3a65c9a. Read the comment docs.

@lukechu10 lukechu10 added the performance Performance related label Mar 21, 2022
@github-actions
Copy link

github-actions bot commented Mar 21, 2022

Finished dev [unoptimized + debuginfo] target(s) in 0.04s
 Running `/home/runner/work/sycamore/sycamore/sycamore/target/debug/bench-diff ../../../../js-framework-benchmark/webdriver-ts/results.json`

Benchmark Report

  • wasm-bindgen: the performance goal
  • baseline: performance of sycamore-baseline (typically latest master)
  • update: performance of sycamore (typically recent changes)
  • diff: measures the improvement of update over the baseline
@@                         Performance Diff                          @@

##                       | wasm-bindgen | baseline |  update |  diff ##
#######################################################################
- 01_run1k               |       111.84 |   136.88 |  143.40 |   +4.76%
- 02_replace1k           |       118.74 |   151.22 |  160.37 |   +6.05%
+ 03_update10th1k_x16    |       387.45 |   406.87 |  380.98 |   -6.36%
  04_select1k            |        63.40 |    65.49 |   67.36 |   +2.86%
  05_swap1k              |        95.15 |    96.10 |   93.84 |   -2.35%
  06_remove-one-1k       |        29.39 |    30.33 |   30.52 |   +0.63%
  07_create10k           |      1187.43 |  1643.80 | 1667.24 |   +1.43%
  08_create1k-after1k_x2 |       273.46 |   336.76 |  326.94 |   -2.92%
+ 09_clear1k_x8          |        89.39 |   117.93 |  112.22 |   -4.84%
  21_ready-memory        |         1.26 |     1.23 |    1.23 |   +0.03%
  22_run-memory          |         1.14 |     1.49 |    1.49 |   -0.38%
+ 23_update5-memory      |         1.14 |     1.73 |    1.48 |  -14.25%
- 24_run5-memory         |         1.30 |     1.64 |    1.77 |   +7.58%
- 25_run-clear-memory    |         1.21 |     1.08 |    1.22 |  +13.08%
- 31_startup-ci          |      1844.13 |  1938.90 | 2116.90 |   +9.18%
- 32_startup-bt          |        29.22 |    39.84 |   41.77 |   +4.86%
  34_startup-totalbytes  |       189.16 |   276.50 |  276.55 |   +0.02%

Workflow: 2018856640
Adding new commits will generate a new report

@lukechu10 lukechu10 merged commit 75850ef into master Mar 21, 2022
@lukechu10 lukechu10 deleted the svg-class branch March 21, 2022 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-svg Area: SVG support C-bug Category: bug, something isn't working performance Performance related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

class attribute is not supported in svg element
1 participant