Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NoHydrate and NoSsr utility components #409

Merged
merged 7 commits into from
Apr 30, 2022
Merged

Conversation

lukechu10
Copy link
Member

No description provided.

@lukechu10 lukechu10 added C-enhancement Category: new feature or improvement to existing feature A-SSR Area: Server Side Rendering (SSR) and Static Site Generation (SSG) labels Apr 14, 2022
@lukechu10 lukechu10 marked this pull request as draft April 15, 2022 00:11
@codecov
Copy link

codecov bot commented Apr 27, 2022

Codecov Report

Merging #409 (2dcd7fb) into master (b0b0bbb) will increase coverage by 0.16%.
The diff coverage is 82.00%.

@@            Coverage Diff             @@
##           master     #409      +/-   ##
==========================================
+ Coverage   64.17%   64.34%   +0.16%     
==========================================
  Files          49       49              
  Lines        7872     7925      +53     
==========================================
+ Hits         5052     5099      +47     
- Misses       2820     2826       +6     
Impacted Files Coverage Δ
packages/sycamore/src/html/mod.rs 44.44% <75.67%> (+44.44%) ⬆️
packages/sycamore/src/utils/hydrate/mod.rs 85.57% <100.00%> (+2.06%) ⬆️
packages/sycamore-macro/src/view/ir.rs 100.00% <0.00%> (ø)
packages/sycamore-macro/src/view/parse.rs 96.80% <0.00%> (+0.01%) ⬆️
packages/sycamore-macro/src/view/codegen.rs 96.25% <0.00%> (+0.01%) ⬆️
packages/sycamore/src/noderef.rs 83.05% <0.00%> (+5.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0b0bbb...2dcd7fb. Read the comment docs.

@lukechu10 lukechu10 force-pushed the no-hydrate-and-no-ssr branch from dbfce37 to 7a072c0 Compare April 30, 2022 19:14
@lukechu10 lukechu10 marked this pull request as ready for review April 30, 2022 20:35
@lukechu10 lukechu10 merged commit 864f158 into master Apr 30, 2022
@lukechu10 lukechu10 deleted the no-hydrate-and-no-ssr branch April 30, 2022 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-SSR Area: Server Side Rendering (SSR) and Static Site Generation (SSG) C-enhancement Category: new feature or improvement to existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant