Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify Suspense code and add finished callback to transition.start #414

Merged
merged 3 commits into from
Apr 30, 2022

Conversation

lukechu10
Copy link
Member

No description provided.

@lukechu10 lukechu10 added C-enhancement Category: new feature or improvement to existing feature A-async Area: futures, suspense, and async/await labels Apr 30, 2022
@codecov
Copy link

codecov bot commented Apr 30, 2022

Codecov Report

Merging #414 (44d8aa0) into master (e21b576) will decrease coverage by 0.14%.
The diff coverage is 92.30%.

❗ Current head 44d8aa0 differs from pull request most recent head cbfd847. Consider uploading reports for the commit cbfd847 to get more accurate results

@@            Coverage Diff             @@
##           master     #414      +/-   ##
==========================================
- Coverage   64.16%   64.01%   -0.15%     
==========================================
  Files          49       49              
  Lines        7886     7862      -24     
==========================================
- Hits         5060     5033      -27     
- Misses       2826     2829       +3     
Impacted Files Coverage Δ
packages/sycamore/src/suspense.rs 86.66% <92.30%> (-3.64%) ⬇️
packages/sycamore-reactive/src/effect.rs 99.31% <0.00%> (-0.03%) ⬇️
packages/sycamore-reactive/src/lib.rs 95.45% <0.00%> (ø)
packages/sycamore-reactive/src/arena.rs 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e21b576...cbfd847. Read the comment docs.

@lukechu10 lukechu10 merged commit b0b0bbb into master Apr 30, 2022
@lukechu10 lukechu10 deleted the transition-improvements branch April 30, 2022 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-async Area: futures, suspense, and async/await C-enhancement Category: new feature or improvement to existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant