You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This just lets users use the body element. I'm not at all familiar with this part of the codebase, so please let me know if there's anything else I need to do to make this work.
Once this is merged, a new beta release would be greatly appreciated so that Perseus can take advantage of this as soon as possible!
Unfortunately, the http-request-builder example broke because we're using the body as an identifier. This conflict problem between html tags and identifiers should be fixed with #416 because of changes to the element macro codegen. If you don't mind, I'll just edit this PR so as to fix the example and I'll merge this.
Merging #420 (88424bb) into master (33c4f0f) will not change coverage.
The diff coverage is n/a.
❗ Current head 88424bb differs from pull request most recent head c24da22. Consider uploading reports for the commit c24da22 to get more accurate results
commit 3b3e39e
Author: arctic_hen7 <arctic_hen7@pm.me>
Date: Tue May 17 02:50:59 2022 +1000
Add support for `body` (#420)
* feat: added support for `body` element
* Fix http-request-builder example
The previous change added the `<body>` html tag which conflicts with the identifiers used in this example
* Satisfy cargo clippy
Co-authored-by: Luke Chu <lukewchu@outlook.com>
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This just lets users use the
bodyelement. I'm not at all familiar with this part of the codebase, so please let me know if there's anything else I need to do to make this work.Once this is merged, a new beta release would be greatly appreciated so that Perseus can take advantage of this as soon as possible!