Add the prop:* directive to the view macro
#435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the ability to set properties directly in the view macro that accepts any value that can be coverted into the `JsValue`. Supports both static and dynamic values in the same manner that attributes do currently. Updates some of the examples to use the new directive when the type can be used directly as a property instead of cloning or serializing the value.
Codecov Report
@@ Coverage Diff @@
## master #435 +/- ##
==========================================
+ Coverage 64.97% 64.99% +0.02%
==========================================
Files 52 52
Lines 8268 8305 +37
==========================================
+ Hits 5372 5398 +26
- Misses 2896 2907 +11
Continue to review full report at Codecov.
|
Checks that literal values are accepted as property values.
|
Lets see if I can make Codecov happy this time :) |
|
Codecov is indeed happy this time but don't worry too much about it. The reason is that half of our test suite does not actually count towards coverage because they run only in wasm. In fact, our coverage should be much better than what it shows. |
lukechu10
approved these changes
Jun 18, 2022
|
Sorry for taking so long to review. LGTM. As for the docs, I'm planning on rehauling it anyways, so I'll handle that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ability to set properties directly in the view macro that
accepts any value that can be converted into the
JsValue.Supports both static and dynamic values in a similar manner that
attributes do currently.
Updates some of the examples to use the new directive when the type can
be used directly as a property instead of cloning or serializing the
value.
I did update the website to include a section on this new directive but there
is not a similar section for the builder API, so I'm not sure if you want to keep
this out or whether you'd like me to add something similar for the builder docs :).
Closes #330