Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add debug impl for RouterBaseProps #442

Merged
merged 1 commit into from
Jun 26, 2022

Conversation

mc1098
Copy link
Contributor

@mc1098 mc1098 commented Jun 26, 2022

Missing debug after #441 added by #434.

I noticed this because the website failed to build.

@codecov
Copy link

codecov bot commented Jun 26, 2022

Codecov Report

Merging #442 (310c0e1) into master (c8deaee) will decrease coverage by 0.11%.
The diff coverage is 68.00%.

@@            Coverage Diff             @@
##           master     #442      +/-   ##
==========================================
- Coverage   64.69%   64.58%   -0.12%     
==========================================
  Files          52       52              
  Lines        8348     8400      +52     
==========================================
+ Hits         5401     5425      +24     
- Misses       2947     2975      +28     
Impacted Files Coverage Δ
website/src/versions.rs 0.00% <ø> (ø)
packages/sycamore-router/src/router.rs 25.17% <9.09%> (-1.83%) ⬇️
packages/sycamore-router/src/lib.rs 96.95% <95.74%> (+0.18%) ⬆️
packages/sycamore-macro/src/view/ir.rs 100.00% <100.00%> (ø)
packages/sycamore-router-macro/src/route.rs 89.76% <100.00%> (+0.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea67648...310c0e1. Read the comment docs.

@lukechu10
Copy link
Member

Thanks!

@lukechu10 lukechu10 merged commit 41af3c1 into sycamore-rs:master Jun 26, 2022
@mc1098 mc1098 deleted the router-base-props-debug branch June 27, 2022 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants