Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse new view syntax #460

Merged
merged 4 commits into from
Jul 26, 2022
Merged

Parse new view syntax #460

merged 4 commits into from
Jul 26, 2022

Conversation

lukechu10
Copy link
Member

Closes #457

@lukechu10 lukechu10 added A-macro Area: macros BREAKING CHANGE Breaking changes introduced in this PR A-view Area: view! macro labels Jul 26, 2022
@lukechu10 lukechu10 added this to the v0.8 milestone Jul 26, 2022
@codecov
Copy link

codecov bot commented Jul 26, 2022

Codecov Report

Merging #460 (28b8def) into master (ba0efba) will decrease coverage by 0.00%.
The diff coverage is 72.09%.

@@            Coverage Diff             @@
##           master     #460      +/-   ##
==========================================
- Coverage   64.53%   64.53%   -0.01%     
==========================================
  Files          52       52              
  Lines        8412     8402      -10     
==========================================
- Hits         5429     5422       -7     
+ Misses       2983     2980       -3     
Impacted Files Coverage Δ
packages/sycamore-macro/src/view/ir.rs 100.00% <ø> (ø)
website/src/content.rs 0.00% <0.00%> (ø)
website/src/main.rs 0.57% <0.00%> (ø)
packages/sycamore-router/src/router.rs 25.17% <44.44%> (ø)
packages/sycamore-macro/src/view/codegen.rs 97.37% <100.00%> (+0.03%) ⬆️
packages/sycamore-macro/src/view/parse.rs 98.36% <100.00%> (+1.39%) ⬆️
packages/sycamore/src/suspense.rs 94.57% <100.00%> (-0.05%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba0efba...28b8def. Read the comment docs.

@lukechu10 lukechu10 merged commit 49d30f1 into master Jul 26, 2022
@lukechu10 lukechu10 deleted the view-v2 branch July 26, 2022 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-macro Area: macros A-view Area: view! macro BREAKING CHANGE Breaking changes introduced in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

view! syntax v2
1 participant