Allow fragments and dynamic views in RouterBase
#471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukechu10
added
C-enhancement
Codecov Report
@@ Coverage Diff @@
## master #471 +/- ##
==========================================
- Coverage 64.43% 64.39% -0.04%
==========================================
Files 52 52
Lines 8387 8392 +5
==========================================
Hits 5404 5404
- Misses 2983 2988 +5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
Routerwould panic if the children was node a single node. This meant that fragments and dynamic views had to be wrapped by another node (often a<div>or a<main>). This PR removes this restriction.