Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workaround for svg element tags that clash with HTML elements #479

Merged
merged 2 commits into from
Sep 3, 2022

Conversation

lukechu10
Copy link
Member

Some svg tags such as a, title, script and style should now be referenced as svg_a, svg_title, svg_script and svg_style. This is to prevent name clashes with the HTML elements of the same name.

Closes #474

@lukechu10 lukechu10 added the C-enhancement Category: new feature or improvement to existing feature label Sep 3, 2022
@codecov
Copy link

codecov bot commented Sep 3, 2022

Codecov Report

Merging #479 (e407b87) into master (6aab0c2) will not change coverage.
The diff coverage is 37.50%.

@@           Coverage Diff           @@
##           master     #479   +/-   ##
=======================================
  Coverage   64.48%   64.48%           
=======================================
  Files          52       52           
  Lines        8399     8399           
=======================================
  Hits         5416     5416           
  Misses       2983     2983           
Impacted Files Coverage Δ
packages/sycamore/src/web/html.rs 69.82% <37.50%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@lukechu10 lukechu10 force-pushed the svg-missing-elements branch from 12f3238 to e407b87 Compare September 3, 2022 05:33
@lukechu10 lukechu10 merged commit 0e0220b into master Sep 3, 2022
@lukechu10 lukechu10 deleted the svg-missing-elements branch September 3, 2022 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category: new feature or improvement to existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can’t create SVG <a>, <script>, <style> or <title>
1 participant