Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce allocations and dynamic dispatch in effects and memos #599

Closed
wants to merge 3 commits into from

Conversation

lyphyser
Copy link

This series of commits removes unnecessary allocations in effects and memos and makes calling effect callbacks only do a single dynamic dispatch rather than two.

@codecov
Copy link

codecov bot commented Apr 13, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.07 🎉

Comparison is base (3885a9e) 60.52% compared to head (41ff2b6) 60.60%.

❗ Current head 41ff2b6 differs from pull request most recent head 9acfa5d. Consider uploading reports for the commit 9acfa5d to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #599      +/-   ##
==========================================
+ Coverage   60.52%   60.60%   +0.07%     
==========================================
  Files          56       56              
  Lines        9380     9399      +19     
==========================================
+ Hits         5677     5696      +19     
  Misses       3703     3703              
Impacted Files Coverage Δ
packages/sycamore-reactive/src/effect.rs 99.44% <100.00%> (+0.03%) ⬆️
packages/sycamore-reactive/src/memo.rs 100.00% <100.00%> (ø)
packages/sycamore-reactive/src/signal.rs 86.38% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@lukechu10 lukechu10 self-requested a review May 4, 2023 08:27
@lukechu10
Copy link
Member

Supserseded by #626

@lukechu10 lukechu10 closed this Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants