Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make batch affect both memos and effects #631

Merged
merged 1 commit into from
Oct 6, 2023

Conversation

lukechu10
Copy link
Member

@lukechu10 lukechu10 commented Oct 6, 2023

Also simplifies effects by simply making them into memos that have a value of ().

Follow-up to #626
Supersedes #601

Also simplifies effects by simply making them into memos that have a value of `()`.
@lukechu10 lukechu10 added C-bug Category: bug, something isn't working A-reactivity Area: reactivity and state handling performance Performance related labels Oct 6, 2023
@lukechu10 lukechu10 merged commit 42c1294 into sycamore-rs:master Oct 6, 2023
12 checks passed
@lukechu10 lukechu10 deleted the reactivity-batch branch October 6, 2023 16:17
@github-actions
Copy link

github-actions bot commented Oct 6, 2023

Benchmark Report

  • wasm-bindgen: the performance goal
  • baseline: performance of sycamore-baseline (typically latest master)
  • update: performance of sycamore (typically recent changes)
  • diff: measures the improvement of update over the baseline
@@                           Performance Diff                           @@

##                          | wasm-bindgen | baseline |  update |  diff ##
##########################################################################
  01_run1k                  |        11.30 |    22.21 |   22.00 |   -0.97%
  02_replace1k              |        18.72 |    38.56 |   38.04 |   -1.35%
+ 03_update10th1k_x16       |        10.28 |    16.12 |   11.86 |  -26.42%
  04_select1k               |         1.90 |    31.47 |   30.53 |   -2.99%
+ 05_swap1k                 |         0.78 |     2.55 |    2.43 |   -4.98%
+ 06_remove-one-1k          |         0.81 |     3.18 |    2.68 |  -15.87%
  07_create10k              |       112.91 |   270.80 |  275.39 |   +1.70%
  08_create1k-after1k_x2    |        21.43 |    49.09 |   49.83 |   +1.51%
- 09_clear1k_x8             |        61.85 |    69.92 |   76.33 |   +9.18%
  21_ready-memory           |         1.71 |     1.75 |    1.75 |   -0.02%
  22_run-memory             |         2.96 |     4.91 |    4.85 |   -1.31%
  23_update5-memory         |         2.93 |     5.02 |    4.96 |   -1.24%
+ 25_run-clear-memory       |         1.81 |     3.66 |    3.54 |   -3.42%
  26_run-10k-memory         |        14.90 |    41.81 |   41.18 |   -1.50%
- 31_startup-ci             |      1964.75 |  1914.44 | 2269.83 |  +18.56%
- 32_startup-bt             |        24.15 |    35.69 |   71.14 |  +99.36%
  33_startup-mainthreadcost |       318.23 |   380.62 |  381.69 |   +0.28%
  34_startup-totalbytes     |       185.58 |   300.35 |  299.27 |   -0.36%

Workflow: 6433913291
Adding new commits will generate a new report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-reactivity Area: reactivity and state handling C-bug Category: bug, something isn't working performance Performance related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant