Re-export wasm-bindgen, js-sys, and event types from web-sys
#642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…en/sycamore into blainehansen-convenience-reexports
web-sys relies very haevily of feature flags to determine which parts of the API is compiled. Sycamore itself enables a subset of these flags but in many cases, the downstream user will need to add web-sys anyways should they wish to use an API not enabled by Sycamore.
lukechu10
added
C-enhancement
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #642 +/- ##
=======================================
Coverage 61.19% 61.19%
=======================================
Files 55 55
Lines 9022 9022
=======================================
Hits 5521 5521
Misses 3501 3501
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #568
This adds a re-export in
sycamore-webofwasm-bindgen,js-sys, and only the event types fromweb-syswhich are used from within Sycamore.The reason why we don't re-export the entirety of
web-sysis because all of the APIs are behind feature flags so it is very likely that the downstream user of Sycamore will need to addweb-sysas a dependency anyways.