Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Router example to use non-referenced ReadSignal #647

Merged
merged 2 commits into from
Nov 26, 2023

Conversation

noxxxxxious
Copy link
Contributor

@noxxxxxious noxxxxxious commented Nov 26, 2023

Also rerendered docs

Copy link

codecov bot commented Nov 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (28b9106) 61.19% compared to head (3c694ca) 61.12%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #647      +/-   ##
==========================================
- Coverage   61.19%   61.12%   -0.08%     
==========================================
  Files          55       55              
  Lines        9022     9059      +37     
==========================================
+ Hits         5521     5537      +16     
- Misses       3501     3522      +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lukechu10 lukechu10 added the A-docs Area: documentation label Nov 26, 2023
Copy link
Member

@lukechu10 lukechu10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's another instance of the same problem on Line 251.

Also could you remove the .as_ref() while you're at it? Thanks!

@noxxxxxious
Copy link
Contributor Author

That should do it!

Copy link
Member

@lukechu10 lukechu10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome thanks!

@lukechu10 lukechu10 merged commit 16acf8e into sycamore-rs:master Nov 26, 2023
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-docs Area: documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants