Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add track_caller attribute to provide_context* and use_context functions #667

Merged
merged 1 commit into from
Mar 23, 2024

Conversation

lukechu10
Copy link
Member

This let's us get the line and col info of the panic at the call site rather than in library code.

Copy link

codecov bot commented Mar 23, 2024

Codecov Report

Attention: Patch coverage is 20.00000% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 60.44%. Comparing base (7140c12) to head (6c62c42).

Files Patch % Lines
packages/sycamore-reactive/src/context.rs 20.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #667      +/-   ##
==========================================
- Coverage   60.46%   60.44%   -0.02%     
==========================================
  Files          54       54              
  Lines        8542     8543       +1     
==========================================
- Hits         5165     5164       -1     
- Misses       3377     3379       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lukechu10 lukechu10 merged commit 5d46d5e into sycamore-rs:master Mar 23, 2024
8 of 10 checks passed
@lukechu10 lukechu10 deleted the context-add-caller-info branch March 23, 2024 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant